Skip to content

fix: Updated ODM defaults #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dushyantbehl merged 1 commit into from
Dec 3, 2025
Merged

fix: Updated ODM defaults #648

dushyantbehl merged 1 commit into from
Dec 3, 2025

Conversation

@romitjain
Copy link
Collaborator

@romitjain romitjain commented Dec 3, 2025

  1. Updated the documentation to render properly
  2. Updated defaults for ODM, update_interval will be set as eval_steps if not provided, reward_type default is entropy
  3. Fixed a breaking test

@romitjain
Updated ODM defaults
7294240 
Signed-off-by: romitjain <romit@ibm.com>
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@romitjain romitjain changed the title Updated ODM defaults fix: Updated ODM defaults Dec 3, 2025
@github-actions github-actions bot added the fix label Dec 3, 2025
@dushyantbehl dushyantbehl merged commit 890725c into foundation-model-stack:main Dec 3, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dushyantbehl dushyantbehl dushyantbehl approved these changes

@anhuong anhuong Awaiting requested review from anhuong anhuong is a code owner

@aluu317 aluu317 Awaiting requested review from aluu317 aluu317 is a code owner

@fabianlim fabianlim Awaiting requested review from fabianlim fabianlim is a code owner

@kmehant kmehant Awaiting requested review from kmehant kmehant is a code owner

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romitjain @dushyantbehl