Skip to content

chore: fix image build and push actions to automate image build process. #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dushyantbehl merged 4 commits into from
Dec 18, 2025
Merged

chore: fix image build and push actions to automate image build process. #650

dushyantbehl merged 4 commits into from
Dec 18, 2025

Conversation

@dushyantbehl
Copy link
Collaborator

@dushyantbehl dushyantbehl commented Dec 18, 2025 •
edited
Loading

Description of the change

This PR fixes the image build and push plan for the stack by making some clear choices -

  1. Main Branch ->
  • Used for day to day commits
  • On every push (or commit) -> builds and pushes the nvcr image under fms-hf-tuning-dev:latest
  • Developers can use main images for testing
  1. Release Branch ->
  • Used to manage pypi releases
  • On every pull request -> checks the build of UBI9 images
  • On every push -> builds and pushes the UBI9 images under fms-hf-tuning:latest
  • Release images are to be used for product.
  1. Any tag ->
  • On every tag push / gh release publish -> builds and pushes the nvcr image

Related issue number

How to verify the PR

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the chore label Dec 18, 2025
@dushyantbehl
change the image build and push workflows for various branches
d4999cb 
Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com>
@dushyantbehl
push staging images on tags/release
cbc406f 
change image names to be standards
fix nvcr dockerfile

Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com>
@dushyantbehl
remove staging branch
8cc8a0c 
Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com>
ashokponkumar
ashokponkumar previously approved these changes Dec 18, 2025
View reviewed changes
@dushyantbehl
update nvcr dockefile to multistage to save space
5ed66b9 
Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com>
@dushyantbehl dushyantbehl merged commit b3a8a78 into foundation-model-stack:main Dec 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashokponkumar ashokponkumar ashokponkumar approved these changes

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dushyantbehl @ashokponkumar