Skip to content

Conversation

@BrandonGroth
Copy link
Collaborator

@BrandonGroth BrandonGroth commented Jun 23, 2025

Description of the change

This change moves triton to being an optional package. An additional guard was added, along with minor changes to the test script.

Related issues or PRs

N/A

How to verify the PR

Was the PR tested

Triton tests are now skipped on CI/CD rather than passing via a quick return.

tests/triton_kernels/test_triton_mm.py ssssssssssssssssssssssssssssss

Locally, on my machine I am getting 9x failures from one of the tests:

FAILED tests/triton_kernels/test_triton_mm.py::test_triton_matmul_fp[dtype_to_test4-1024] - AssertionError: assert (tensor(1725.2465, device='cuda:0') / tensor(32604.6211, device='cuda:0')) < 1e-05

Checklist for passing CI/CD:

  • All commits are signed showing "Signed-off-by: Name <email@domain.com>" with git commit -signoff or equivalent
  • PR title and commit messages adhere to Conventional Commits
  • Contribution is formatted with tox -e fix
  • Contribution passes linting with tox -e lint
  • Contribution passes spellcheck with tox -e spellcheck
  • Contribution passes all unit tests with tox -e unit

Note: CI/CD performs unit tests on multiple versions of Python from a fresh install. There may be differences with your local environment and the test environment.

@BrandonGroth
Copy link
Collaborator Author

So apparently, I have disabled the triton tests on CI/CD. There are no GPUs, so this is expected behavior.

tests/triton_kernels/test_triton_mm.py ssssssssssssssssssssssssssssss

Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
@chichun-charlie-liu
Copy link
Collaborator

triton assertion error will be addressed by #141 , other than that, lgtm

Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
@chichun-charlie-liu chichun-charlie-liu linked an issue Jun 23, 2025 that may be closed by this pull request
@chichun-charlie-liu chichun-charlie-liu merged commit bcee5f3 into foundation-model-stack:main Jun 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add accumulation triton kernel

2 participants