Skip to content

Conversation

@BrandonGroth
Copy link
Collaborator

@BrandonGroth BrandonGroth commented Jun 24, 2025

Description of the change

This PR moves the following dependencies to optional:

  • tensorboard, notebook added to visualize group
  • ninja, evaluate, and huggingface_hub added to examples group
  • ibm-fms added to aiu group

An error check in run_quant.py using huggingface_hub was removed as it wasn't critical.
Additional guards were added to files in aiu_addons to ensure the ibm-fms is installed.

Related issues or PRs

N/A

How to verify the PR

Checklist for passing CI/CD:

  • All commits are signed showing "Signed-off-by: Name <email@domain.com>" with git commit -signoff or equivalent
  • PR title and commit messages adhere to Conventional Commits
  • Contribution is formatted with tox -e fix
  • Contribution passes linting with tox -e lint
  • Contribution passes spellcheck with tox -e spellcheck
  • Contribution passes all unit tests with tox -e unit

Note: CI/CD performs unit tests on multiple versions of Python from a fresh install. There may be differences with your local environment and the test environment.

Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
…l dep

Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
@chichun-charlie-liu chichun-charlie-liu merged commit 9b75c10 into foundation-model-stack:main Jun 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants