Skip to content

Conversation

@BrandonGroth
Copy link
Collaborator

Description of the change

This PR fixes a bug for recipes loaded with qconfig_init. Previous behavior would overwrite any recipe with the qconfig defaults, which is NOT desired. This now only updates a loaded recipe IF the entry doesn't already exist in the requested qconfig.

Also, a new test was added (tests/models/test_saveconfig/test_save_init_recipe) to ensure this behavior is consistent.

Related issues or PRs

Closes #150

How to verify the PR

Run pytest tests/models/test_saveconfig.py

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added (if that coverage is difficult, please briefly explain the reason)
  • I have ensured all unit tests pass

Checklist for passing CI/CD:

  • All commits are signed showing "Signed-off-by: Name <email@domain.com>" with git commit -signoff or equivalent
  • PR title and commit messages adhere to Conventional Commits
  • Contribution is formatted with tox -e fix
  • Contribution passes linting with tox -e lint
  • Contribution passes spellcheck with tox -e spellcheck
  • Contribution passes all unit tests with tox -e unit

Note: CI/CD performs unit tests on multiple versions of Python from a fresh install. There may be differences with your local environment and the test environment.

Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
@BrandonGroth BrandonGroth self-assigned this Jun 27, 2025
@github-actions github-actions bot added the fix label Jun 27, 2025
@BrandonGroth BrandonGroth changed the title fix: fix: Saved qconfig recipe being overwritten with defaults Jun 27, 2025
@BrandonGroth BrandonGroth merged commit 7167028 into foundation-model-stack:main Jul 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Saved qconfig recipe info is being destroyed on load

2 participants