fix: Saved qconfig recipe being overwritten with defaults #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes a bug for recipes loaded with qconfig_init. Previous behavior would overwrite any recipe with the qconfig defaults, which is NOT desired. This now only updates a loaded recipe IF the entry doesn't already exist in the requested qconfig.
Also, a new test was added (
tests/models/test_saveconfig/test_save_init_recipe) to ensure this behavior is consistent.Related issues or PRs
Closes #150
How to verify the PR
Run
pytest tests/models/test_saveconfig.pyWas the PR tested
Checklist for passing CI/CD:
git commit -signoffor equivalenttox -e fixtox -e linttox -e spellchecktox -e unitNote: CI/CD performs unit tests on multiple versions of Python from a fresh install. There may be differences with your local environment and the test environment.