Skip to content

Conversation

@chichun-charlie-liu
Copy link
Collaborator

Description of the change

available_packages dict in fms_mo.utils.import_utils had some issue detecting fms even though it's installed and functioning.

Related issues or PRs

minor bug, reported by Alberto through Slack directly.

How to verify the PR

this is a test on a certain linux machine that has fms installed but not mx

<on a certain linux machine>:~/projects/fms-mo-fork$ python
Python 3.12.11 | packaged by conda-forge | (main, Jun  4 2025, 14:45:31) [GCC 13.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from fms_mo.utils.import_utils import available_packages
GPTQModel is not properly installed. QLinearExv1WI4AF16 and QLinearExv2WI4AF16 wrappers will not be available.
>>> available_packages["mx"]
False
>>> available_packages["fms"]
True
>>> exit()

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added (if that coverage is difficult, please briefly explain the reason)
  • I have ensured all unit tests pass

Checklist for passing CI/CD:

  • All commits are signed showing "Signed-off-by: Name <email@domain.com>" with git commit -signoff or equivalent
  • PR title and commit messages adhere to Conventional Commits
  • Contribution is formatted with tox -e fix
  • Contribution passes linting with tox -e lint
  • Contribution passes spellcheck with tox -e spellcheck
  • Contribution passes all unit tests with tox -e unit

Note: CI/CD performs unit tests on multiple versions of Python from a fresh install. There may be differences with your local environment and the test environment.

Signed-off-by: cliu-us <cliu@us.ibm.com>
@chichun-charlie-liu chichun-charlie-liu changed the title fix available_packages fix: fix available_packages Jun 27, 2025
@github-actions github-actions bot added the fix label Jun 27, 2025
Signed-off-by: cliu-us <cliu@us.ibm.com>
Copy link
Collaborator

@andrea-fasoli andrea-fasoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks for the prompt fix!

@chichun-charlie-liu chichun-charlie-liu merged commit e8f35bb into foundation-model-stack:main Jun 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants