fix: finish missed items for upgrading to python 3.12 #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cliu-us <cliu@us.ibm.com>
chichun-charlie-liu
requested review from
BrandonGroth,
andrea-fasoli,
kcirred,
nwang-ibm and
tharapalanivel
as code owners
BrandonGroth
approved these changes
Mar 29, 2025
Collaborator
Author
|
spell check failed due to package missing, possibly something to do with workflow images related to py3.12. need @tharapalanivel 's help to confirm the root cause. |
chichun-charlie-liu
merged commit 33fe3d0
into
foundation-model-stack:main
12 of 13 checks passed
Collaborator
tharapalanivel
left a comment
tharapalanivel
left a comment
There was a problem hiding this comment.
Thanks @chichun-charlie-liu for getting to these changes promptly, can we make the README updates regarding python versions too please? Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
a few minor settings was missing in previous PR #83
Related issue number
How to verify the PR
Was the PR tested