Skip to content

Conversation

@swith004
Copy link
Collaborator

@swith004 swith004 commented May 2, 2025

What this PR does

This PR adds a small API server boot test for the vllm-detector-adapter server. The smoke tests makes a call to the health endpoint to verify no issues with the server starting up. Additionally, utilities and fixtures are added here to make it easy to expand tests scope in the future. ...

How this was tested

This was tested to pass by installing prerequisites, and running the following:

pytest tests/test_http_server.py 

swith004 added 5 commits May 2, 2025 13:54
…apter

Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
@swith004 swith004 marked this pull request as draft May 2, 2025 20:41
@swith004
Copy link
Collaborator Author

swith004 commented May 2, 2025

While the smoke tests passes locally, it does not pass the build and tests tox build for reasons that need to be debugged...

swith004 added 11 commits May 2, 2025 15:55
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
@swith004
Copy link
Collaborator Author

swith004 commented May 6, 2025

Opened another PR for this as this has too much build history. Closing this draft

@swith004 swith004 closed this May 6, 2025
@swith004 swith004 deleted the vllm_server_health_check_53 branch May 6, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant