Conversation
|
This PR has been automatically marked as stale because it has not had any activity in the last 7 days. It will be closed if no further activity occurs in the next 7 days. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 5 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
| if (!sourceId) { | ||
| console.warn(`No source ID found for text: "${sourceText}"`) | ||
| continue | ||
| } |
There was a problem hiding this comment.
Import matches by text instead of trans-unit ID
High Severity
createValuesBySourceFromXliff builds a sourceTextToId map keyed by source text to look up source IDs during import. When multiple localization sources share the same text value, only the last one's ID is stored in the map, causing translations for the other sources to be silently dropped or misapplied. The export already writes source.id as the trans-unit id attribute, so the import could read it directly from the element via unit.getAttribute("id") instead.
madebyisaacr
force-pushed
the
crowdin
branch
from
af265c9 to
4492d22
Compare
3 participants
Description
Crowdin plugin
Based on #472
Slack thread: https://framer-team.slack.com/archives/C06L5H5ADK2/p1769610843782959
Design: https://framer.com/projects/Crowdin-Plugin--En0e1ZdDld9pYACTw5HL-6OsNz?node=t8O8FPvti
Testing