Skip to content

Conversation

@Daan0709
Copy link
Contributor

  • Restructured API to fetch using /{projectname}/{configurationname}
  • Projects are now stored in memory and can be updated by saving XML in the editor page
  • Adapters can now be opened in the monaco editor: Automatically highlights the opened adapter
  • Editor has suggestions from frankdoc-elements, automatically inserts mandatory attributes, and suggests attributes when typing within a tag

Closes #110

@Daan0709 Daan0709 self-assigned this Oct 30, 2025
@Daan0709 Daan0709 requested a review from philipsens October 30, 2025 12:18
Copy link
Member

@philipsens philipsens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a long time to understand some of the logic. I think this code can improve a lot in readability. It might be nice to do a little refactor together so you can see where I'm coming from.

Copy link

Copilot AI commented Nov 4, 2025

@philipsens I've opened a new pull request, #117, to work on those changes. Once the pull request is ready, I'll request review from you.

@Daan0709
Copy link
Contributor Author

Daan0709 commented Nov 6, 2025

Applied the feedback, and I agree that I should chill with the nesting a bit 😄 Quick and easy to write, but difficult to decipher at times, even for my own code looking back at it a week later.

@Daan0709 Daan0709 requested a review from philipsens November 13, 2025 09:48
@Daan0709 Daan0709 merged commit fd7679e into master Nov 20, 2025
1 check passed
@Daan0709 Daan0709 deleted the open-files-in-editor branch November 20, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open files in the editor

3 participants