Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds SQL formatting capabilities to the Monaco editor by integrating the sql-formatter library. The implementation creates a reusable hook that registers document and range formatting providers, enabling users to format their SQL code both for entire documents and selected ranges with proper error handling.
Key Changes:
- Added
sql-formatterlibrary as a dependency for SQL formatting functionality - Created
useSqlFormattingProvidershook to encapsulate formatting provider registration logic - Enabled
formatOnPasteoption in the Monaco editor for improved user experience
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
ui/package.json |
Added sql-formatter dependency to enable SQL formatting features |
ui/src/lib/monaco/sql-formatting.ts |
Implemented reusable hook for registering document and range formatting providers with error handling |
ui/src/lib/monaco/index.ts |
Exported the new formatting hook for use in components |
ui/src/components/editor.tsx |
Integrated formatting providers using the new hook and enabled format-on-paste |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thank you. I will handle the AI reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces SQL formatting capabilities to the Monaco editor by integrating the
sql-formatterlibrary and adding formatting providers. The main changes focus on improving the SQL editing experience by enabling automatic formatting for both entire documents and selected ranges, and refactoring formatting logic into a dedicated hook for better code organization.SQL Formatting Integration:
sql-formatteras a dependency topackage.jsonto enable SQL formatting features.useSqlFormattingProvidershook inui/src/lib/monaco/sql-formatting.tsto register document and range formatting providers for SQL in Monaco, using sensible defaults and error handling.ui/src/lib/monaco/index.tsfor use in other components.Editor Component Enhancements:
useSqlFormattingProvidersinui/src/components/editor.tsx, keeping the component lean and maintainable. [1] [2]