Open
Conversation
Owner
|
I like this idea but I think we should completely infer it from the library, not re-declare it, otherwise maintenance will be hard. Let me have a stab at it later today! |
Owner
|
Actually my life is a bit of a mess right now, can you have a stab at inferring it from the library instead of declaring? I’m happy to review just in complete mayhem right now |
Author
|
I managed to infer the options type from the createBrowserRouter function. Added a simple test just to test Typescript correctly infers the type. |
Author
|
any news on this? Still have the need for it :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am missing the possibility to use the options on the browserRouter.
https://reactrouter.com/en/main/routers/create-browser-router
Sadly the
DOMRouterOptsis not exported therefore I simply copied it with the types from base package.If you have a better solution for that, just let me know.
I did not add any tests, cause I am not really familiar with testing-library. Just let me know how to test this.