Don't overwrite /usr/local/etc/pkg/repos/FreeBSD.conf #1925
Conversation
|
Thank you for taking the time to contribute to FreeBSD! |
Thanks; 291502 will need a change to the |
|
I have updated the commit, removing the 'file' word in line 4, thanks for the review. I will make an pull request about Bug 291502. |
|
I'm not sure if I understand, We do want to overwrite it if it exists because if the old repo is there, it will conflict, right? |
|
@concussious Of course, if the user didn't choose pkgbase the Edit: I'm not sure if the comment on line 9 is still relevant, maybe when/if pkgbase becomes the default it should be removed. Edit: I just noticed that the other FreeBSD.conf.latest and FreeBSD.conf.quaterly-release also has the same comment. If we agree that this is the better option I will edit those files in this PR also. |
|
If you're changing one of these files you should change all of them to match, the header is copied between them |
Simply: with pkgbase, it's unwanted, because the system will cease to gain fixes for errata and security. |
I don't see an option to approve, but I think the changes to the three files are fairly non-contentious. Thanks! Commit log message nits:
I can't remember the exact guidance, but character limits might be 50 for the first line, 72 for subsequent lines. 49 characters (food for thought):
|
|
I will make those changes and make another commit here and send the patch on bugzilla, thank you for your guidance. Edit: You are right about mentioning |
No please, the patch is in the right place. Bugzilla is the most inconvenient place for us to receive patches. It literally has no mechanism for code review. Who keeps saying to do that? |
|
The closing was an accidental fat fingering, apologies. |
A lot of people, but I would upstream the changes to GitHub also. Don't worry. |
Who are those people? They need to be kindly updated on the information.
No, that is wrong because it duplicates work and makes a mess of the paper trail. From CONTRIBUTING.Md, paragraph four: "A change should be submitted by only one method. For example, please do not open a GitHub pull request and create a Phabricator review for the same change (unless explicitly requested to do so by a FreeBSD committer)."
As a maintainer it is my job to worry :) |
I'm new to contributing to FreeBSD so, i though I would need some information, I have read the CONTRIBUTING.Md as you said above but also by people chatting on Discord. One of the discussions where about how the ways FreeBSD is currently accepting patches is splitted across multiple platforms one advice I read was that sending on bugzilla was also good (something that I don't quite remember why, but I think it was because most of the maintainers did read more bugzilla)
That being said, I will follow what you said. I did in fact choose this small "problem" because I was aware of how things could become messy. I apologize for that. I will keep the changes here then. Thank you! |
The files /usr/sbin/pkg/FreeBSD.conf.* currently set base repo to {enable: no}.
We don't want to overwrite /local/etc/pkg/repos/FreeBSD.conf that already exists
when users choose tech preview in the installation.
Signed-off-by: Guilherme Augusto de Souza Candinho <cndghm@gmail.com>
Can you please share the project policy with them if you go back there? It creates extra work and confusion if the patch is multiple places. That discord server is unaffiliated with the project and is not run by project members. See: https://wiki.freebsd.org/Discord/DiscordServer
No need to apologize. The fragmentation creates these problems for all of us. Thank you for your attention to these details and your submission. |
|
Sure! I'm make a comment about the current guidelines next time I go to the Discord Server. Didn't know it was unofficial. |
4 participants
As addressed by Bug 291501 and Bug 291502.
The append redirection operator can be used since the first time because if the user is using pkgbase, the file /usr/local/etc/pkg/repos/FreeBSD.conf already exists.