Allow to build main on Intel macOS 26

[opntr]

Compiling FreeBSD main (16-CURRENT) on Intel MBP with latest macOS trigger build errors.

[emaste]

Generally looks good. For thr_printf.c we could perhaps introduce nonstring or use { '0', '1', .... I see there have been a few recent commits for nonstring but I don't think we have a project policy yet.

[opntr]

Yes, I agree. I've already introduced the __nonstring define in cdefs.h. The only question is about the style of the usage:

a)

__nonstring type var = "foo";

or

b)

type var __nonstring = "foo";

is preferred?

[github-actions]

Thank you for taking the time to contribute to FreeBSD!
All issues resolved.

[opntr]

and I've just found now @arichardson 's PR: #1847 which mostly contains my fixes

[arichardson]

Thanka for this contribution. For the nonstring I already have some approved phabricator revisions that I just need to land. I plan to do so tomorrow.

[arichardson]

Apologies for being slow in landing these, other priorities have taken up all my time lately

[opntr]

@arichardson do you need any help?

[opntr]

I will rework this branch to only contain the fixes for Intel mac, I will test your changes ontop of the intel fix

[opntr]

@emaste could you please take a look again?

[arichardson]

Hmm this one is weird, we shouldn't be generating any files here, everything should be in the build dir.

[arichardson]

@arichardson do you need any help?

I committed my initial set of changes and will rebase the remaining ones soon. This is enough to pass the host tools phase, but the buildworld phase still needs the additional fixes for latest clang.

[arichardson]

Okay I've updated #1847, hopefully I can land the rest of the changes soon.

[opntr]

Seems like vi/catalog is also weird:

... swedish.UTF-8
echo "... zh_CN.UTF-8";                                                  rm -f zh_CN.UTF-8;                                                      env LC_ALL=C sort -u zh_CN.UTF-8.base |                                 awk '{         
                                                 if ($1 == 1) {                                          print "\nMESSAGE NUMBER 1 IS NOT LEGAL";  exit 1;                                                 }                      
                                 if (++nline > $1) {                                     print "DUPLICATE MESSAGE NUMBER " $1;           exit 1;                                                 }                              
                         print $0;        }' |                                                             sed -e '1s/^/$set 1~$quote "~/; 1y/~/\n/' |                     gencat zh_CN.UTF-8 /dev/stdin;                                 
         chmod 444 zh_CN.UTF-8;                                                  if grep DUPLICATE zh_CN.UTF-8 > /dev/null; then                                 grep DUPLICATE zh_CN.UTF-8;                                       fi;            
                                                 if grep 'NOT LEGAL' zh_CN.UTF-8 > /dev/null; then                       grep 'NOT LEGAL' zh_CN.UTF-8;                                   fi
... zh_CN.UTF-8
echo "... ru_RU.UTF-8";                                                  rm -f ru_RU.UTF-8;                                                      env LC_ALL=C sort -u ru_RU.UTF-8.base |                                 awk '{         
                                                 if ($1 == 1) {                                          print "\nMESSAGE NUMBER 1 IS NOT LEGAL";  exit 1;                                                 }                      
                                 if (++nline > $1) {                                     print "DUPLICATE MESSAGE NUMBER " $1;           exit 1;                                                 }                              
                         print $0;        }' |                                                             sed -e '1s/^/$set 1~$quote "~/; 1y/~/\n/' |                     gencat ru_RU.UTF-8 /dev/stdin;                                 
         chmod 444 ru_RU.UTF-8;                                                  if grep DUPLICATE ru_RU.UTF-8 > /dev/null; then                                 grep DUPLICATE ru_RU.UTF-8;                                       fi;            
                                                 if grep 'NOT LEGAL' ru_RU.UTF-8 > /dev/null; then                       grep 'NOT LEGAL' ru_RU.UTF-8;                                   fi
... ru_RU.UTF-8
echo "... uk_UA.UTF-8";                                                  rm -f uk_UA.UTF-8;                                                      env LC_ALL=C sort -u uk_UA.UTF-8.base |                                 awk '{         
                                                 if ($1 == 1) {                                          print "\nMESSAGE NUMBER 1 IS NOT LEGAL";  exit 1;                                                 }                      
                                 if (++nline > $1) {                                     print "DUPLICATE MESSAGE NUMBER " $1;           exit 1;                                                 }                              
                         print $0;        }' |                                                             sed -e '1s/^/$set 1~$quote "~/; 1y/~/\n/' |                     gencat uk_UA.UTF-8 /dev/stdin;                                 
         chmod 444 uk_UA.UTF-8;                                                  if grep DUPLICATE uk_UA.UTF-8 > /dev/null; then                                 grep DUPLICATE uk_UA.UTF-8;                                       fi;            
                                                 if grep 'NOT LEGAL' uk_UA.UTF-8 > /dev/null; then                       grep 'NOT LEGAL' uk_UA.UTF-8;                                   fi
... uk_UA.UTF-8
op@opmbp src % git status
On branch op/main
Your branch is ahead of 'origin/op/main' by 1 commit.
  (use "git push" to publish your local commits)

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        usr.bin/vi/catalog/dump
        usr.bin/vi/catalog/dutch
        usr.bin/vi/catalog/dutch.UTF-8
        usr.bin/vi/catalog/english
        usr.bin/vi/catalog/english.base
        usr.bin/vi/catalog/french
        usr.bin/vi/catalog/french.UTF-8
        usr.bin/vi/catalog/german
        usr.bin/vi/catalog/german.UTF-8
        usr.bin/vi/catalog/polish
        usr.bin/vi/catalog/polish.UTF-8
        usr.bin/vi/catalog/ru_RU.KOI8-R
        usr.bin/vi/catalog/ru_RU.UTF-8
        usr.bin/vi/catalog/spanish
        usr.bin/vi/catalog/spanish.UTF-8
        usr.bin/vi/catalog/swedish
        usr.bin/vi/catalog/swedish.UTF-8
        usr.bin/vi/catalog/tr_TR.ISO8859-9
        usr.bin/vi/catalog/tr_TR.UTF-8
        usr.bin/vi/catalog/uk_UA.KOI8-U
        usr.bin/vi/catalog/uk_UA.UTF-8
        usr.bin/vi/catalog/zh_CN.GB2312
        usr.bin/vi/catalog/zh_CN.UTF-8

nothing added to commit but untracked files present (use "git add" to track)

[opntr]

With the in macOS (clang-17) and these patches the world built finally. But it seems like the tests polluting the src:

[jrtc27]

But both x86_64 and amd64 match 64. This was only here for Apple Silicon because MACHINE_ARCH is arm, no 64 in it.

[jrtc27]

This is entirely unrelated to building on Intel macOS?

[jrtc27]

(and V=0 is not how you silence building FreeBSD, that's you assuming a Linux-ism applies to building FreeBSD and blindly setting a random variable for the build; if you want the FreeBSD build to be quieter, use -s, or -ss for even quieter)

[jrtc27]

All hunks are contested

[jrtc27]

How are you building in order to get that result?