Modify task extensions to support backgroundTask#260
Open
amongonz wants to merge 2 commits intofsprojects:mainfrom
Open
Modify task extensions to support backgroundTask#260amongonz wants to merge 2 commits intofsprojects:mainfrom
amongonz wants to merge 2 commits intofsprojects:mainfrom
Conversation
Modifies the extensions to TaskBuilder to extend TaskBuilderBase instead, so they apply to both the task and backgroundTask builders.
Member
|
Oops, your PR went unnoticed for some time, sorry about that! Thanks @amongonz for finding this bug and tackling it. I will need some accompanying tests to ensure that if anyone changes this again, it will break. I think a single test that didn't compile before with Don't worry if you don't have time to add a test, I can do that as well ;). |
abelbraaksma
requested changes
Feb 20, 2025
| // Add asynchronous for loop to the 'task' computation builder | ||
| type Microsoft.FSharp.Control.TaskBuilder with | ||
| // Add asynchronous for loop to the 'task' and 'backgroundTask' computation builders | ||
| type TaskBuilderBase with |
Member
There was a problem hiding this comment.
Please add a test that shows the use of TaskBuilderBaseBuilder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the for-loop extension to the
taskCE doesn't work withbackgroundTaskbecause the code extendsTaskBuilderinstead of the more generalTaskBuilderBase, from which bothTaskBuilderandBackgroundTaskBuilderinherit.This PR does the small change to support
backgroundTaskas well.