Generate Test Files of the Fix FQN Issues for Modules, Functions, and Properties

[mohbl]

This PR focuses on generating test files to validate fixes for three issues in ts2famix :

1/Duplicate Module FQNs for Top-level and nested ModuleDeclaration nodes (e.g., Namespace1, ParentNamespace.Inner) received duplicate FQNs, causing missing or conflicting Module entities.

2/Missing Arrow/Function Expressions: ArrowFunction and FunctionExpression nodes in CallExpression (e.g., arr.forEach) and ModuleDeclaration (e.g., module Foo) were not assigned unique FQNs, leading to undefined entities (e.g., famixArrow1).

3/Unindexed Properties: PropertyDeclaration nodes in classes were not indexed in buildMethodPositionMap, omitting them from the Famix model.

New test files were created to validate these fixes ModuleDuplicateFQN.test.ts , FunctionAndArrowExpressionFQN.test.ts and one case of the properties were added to the existed file MethodOverloadFQN.test.ts

Thank you, @fuhrmanator , for your review. I apologize for the delay in providing well-structured test files, and I appreciate your patience.

[fuhrmanator]

Christopher Fuhrman, P.Eng., PhD *Professeur au Département de génie logiciel et des technologies de l' je informationÉTS (École de technologie supérieure)* http://profs.etsmtl.ca/cfuhrman Disponibilités: http://tiny.cc/cfuhrmanGoogleCal +1 514 396 8638 *L'ÉTS est une constituante de l'Université du Québec* *Note : Ce message peut avoir été assisté par IA, sans transmission de données personnelles ni confidentielles.*

…

---------- Forwarded message --------- From: belhadj mohamed ***@***.***> Date: Mon, Jun 30, 2025, 07:53 Subject: [fuhrmanator/FamixTypeScriptImporter] Generate Test Files of the Fix FQN Issues for Modules, Functions, and Properties (PR #79) To: fuhrmanator/FamixTypeScriptImporter < ***@***.***> Cc: Christopher (Cris) Fuhrman ***@***.***>, Mention ***@***.***> This PR focuses on generating test files to validate fixes for three issues in ts2famix : 1/Duplicate Module FQNs for Top-level and nested ModuleDeclaration nodes (e.g., Namespace1, ParentNamespace.Inner) received duplicate FQNs, causing missing or conflicting Module entities. 2/Missing Arrow/Function Expressions: ArrowFunction and FunctionExpression nodes in CallExpression (e.g., arr.forEach) and ModuleDeclaration (e.g., module Foo) were not assigned unique FQNs, leading to undefined entities (e.g., famixArrow1). 3/Unindexed Properties: PropertyDeclaration nodes in classes were not indexed in buildMethodPositionMap, omitting them from the Famix model. New test files were created to validate these fixes *ModuleDuplicateFQN.test.ts* , *FunctionAndArrowExpressionFQN.test.ts* and one case of the properties were added to the *existed file MethodOverloadFQN.test.ts* Thank you, @fuhrmanator <https://github.com/fuhrmanator> , for your review. I apologize for the delay in providing well-structured test files, and I appreciate your patience. ------------------------------ You can view, comment on, or merge this pull request online at: #79 Commit Summary - 3900640 <3900640> Fix duplicate FQN errors for nested and top-level modules - f450eb8 <f450eb8> Fix duplicate FQN for ImportEqualsDeclaration\n\nPrevent duplicate FQN errors for ImportEqualsDeclaration nodes by including\ndeclaration names in getFQN - b0e61a9 <b0e61a9> Default constructor parameters without visibility modifiers to public instead of throw error - c5d946b <c5d946b> Skip class accessor errors in createFamixAccess by skipping Famix.Class with debug logs - 9e0507e <9e0507e> Resolve Duplicate FQNs by Indexing Arrow Functions and Function Expressions - 44d5e41 <44d5e41> enhance buildMethodPositionMap to handle well properties - 52510be <52510be> add jest test files for the previous pr File Changes (7 files <https://github.com/fuhrmanator/FamixTypeScriptImporter/pull/79/files>) - *M* src/analyze_functions/process_functions.ts <https://github.com/fuhrmanator/FamixTypeScriptImporter/pull/79/files#diff-d4cf349d204c74e25ac6692d4121070f3a2240a657d4d3e60b89214727acf353> (8) - *M* src/famix_functions/EntityDictionary.ts <https://github.com/fuhrmanator/FamixTypeScriptImporter/pull/79/files#diff-d20baf9c24e71f7998b197b70f9d124ee5f89767c6cba3351b18480fe7e74c6c> (103) - *M* src/famix_functions/helpers_creation.ts <https://github.com/fuhrmanator/FamixTypeScriptImporter/pull/79/files#diff-d178e4d52e599cbe13027f6b5d52117ffe2ebb7736b0ae806815f83ef82dd0f7> (2) - *M* src/fqn.ts <https://github.com/fuhrmanator/FamixTypeScriptImporter/pull/79/files#diff-0c692908261da680d541233e3582ef36278b33a17f38d61b6a9445d1e93c6920> (131) - *A* test/FunctionAndArrowExpressionFQN.test.ts <https://github.com/fuhrmanator/FamixTypeScriptImporter/pull/79/files#diff-04c4604d713ab57bdd05132953a4509446faad6efc0b2b4652bdedfcb052657b> (159) - *M* test/MethodOverloadFQN.test.ts <https://github.com/fuhrmanator/FamixTypeScriptImporter/pull/79/files#diff-aa45620261a3c49e21ae67894772a2435dfe2355a04361b192ce7e4eec81a89c> (125) - *A* test/ModuleDuplicateFQN.test.ts <https://github.com/fuhrmanator/FamixTypeScriptImporter/pull/79/files#diff-0a78aa511ba91beb2cf8b0d67c1aa8ffb4c1f5272dbd3b043dcacad39cfd98f7> (195) Patch Links: - https://github.com/fuhrmanator/FamixTypeScriptImporter/pull/79.patch - https://github.com/fuhrmanator/FamixTypeScriptImporter/pull/79.diff — Reply to this email directly, view it on GitHub <#79>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2BCDBMXB46BKBYUBJIAAT3GEQLZAVCNFSM6AAAAACAOACJ7CVHI2DSMVQWIX3LMV43ASLTON2WKOZTGE4DQMRQGQYTQNY> . You are receiving this because you were mentioned.Message ID: ***@***.***>