refactor(cli): split TemplateEngine into focused single-responsibility services #1202
Annotations
10 warnings
|
Build:
src/Tools/CLI/Services/PackageUpdater.cs#L162
Modify 'CreateBackupAsync' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
Build:
src/Tools/CLI/Services/PackageUpdater.cs#L187
Modify 'RestoreBackupAsync' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
Build:
src/Tools/CLI/Services/PackageUpdater.cs#L137
Modify 'UpdateManifestAsync' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
Build:
src/Tools/CLI/Commands/VersionCommand.cs#L123
Avoid creating a new 'JsonSerializerOptions' instance for every serialization operation. Cache and reuse instances instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1869)
|
|
Build:
src/Tools/CLI/Services/VersionComparer.cs#L140
'string.IndexOf(char)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'FSH.CLI.Services.VersionComparer.ParseVersionParts(string)' with a call to 'string.IndexOf(char, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
Build:
src/Tools/CLI/Services/VersionComparer.cs#L34
Modify 'ParsePackagesProps' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
Build:
src/Tools/CLI/Services/VersionComparer.cs#L118
Remove this unused method parameter 'package'. (https://rules.sonarsource.com/csharp/RSPEC-1172)
|
|
Build:
src/Tools/CLI/Services/VersionComparer.cs#L126
Merge this if statement with the enclosing one. (https://rules.sonarsource.com/csharp/RSPEC-1066)
|
|
Build:
src/Tools/CLI/Services/PackageUpdater.cs#L9
Add a 'private' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
|
|
Build:
src/Tools/CLI/Scaffolding/TemplateRenderer.cs#L14
Remove this unread private field '_templateCache' or refactor the code to use its value. (https://rules.sonarsource.com/csharp/RSPEC-4487)
|
Loading