Skip to content

Conversation

@theferrit32
Copy link
Contributor

…onses. Refresh and clean up all cassettes. Remove all_played checks.

Close #588

…onses. Refresh and clean up all cassettes. Remove all_played checks.
@theferrit32 theferrit32 self-assigned this Nov 16, 2025
@theferrit32 theferrit32 marked this pull request as ready for review November 16, 2025 04:29
@theferrit32 theferrit32 requested review from a team as code owners November 16, 2025 04:29
Copy link
Contributor

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Motivation behind removing all_played?

@theferrit32
Copy link
Contributor Author

@jsstevenson I think these tests should be primarily concerned with the outputs being correct. I don't think the test should fail if an http request which was previously made was not made during a particular run, if the output is still correct. When we're testing the VCF annotator we shouldn't really be concerned with checking the number of http requests made. The cassettes can be cleaned out by just deleting them all and then running again to re-generate them.

I was hitting problems with tests sometimes failing even though the outputs were correct. I think partially related to some lru_cache having or not having a value, and making a test either store another cassette, or skip a cassette, when I wanted to run a single test function or run the tests out of order.

@theferrit32 theferrit32 merged commit 9462037 into main Nov 17, 2025
16 checks passed
@theferrit32 theferrit32 deleted the issue-588-VCR-noise branch November 17, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore and exclude non-useful fields in VCR cassettes

3 participants