Skip to content

fix: handle undefined trigger #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfintal merged 2 commits into from
Jan 19, 2026
Merged

fix: handle undefined trigger #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f39f155
fix: handle when no valid trigger is returned
Arukuen Jan 15, 2026
470f93d
fix: use this._onceOnly
Arukuen Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/frontend/scripts/class-timeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ export class Timeline {
this._onceOnly = !! timelineData.onceOnly
this._actionStarts = {}

// Used to track if the timeline is played per each trigger.
this.timelineData._playedTriggers = new WeakSet()
// Only track played triggers if onceOnly is enabled.
if ( this._onceOnly && ! this.timelineData._playedTriggers ) {
this.timelineData._playedTriggers = new Set()
}
}

this._targets = []
Expand All @@ -44,14 +46,13 @@ export class Timeline {
createInstance( options ) {
// If triggered only once, then we don't create anymore animations.
const currentTrigger = this.interaction.getCurrentTrigger()
if ( this.getRunner().isFrontend ) {
if ( this.timelineData.onceOnly && this.timelineData._playedTriggers.has( currentTrigger ) ) {
if ( this.getRunner().isFrontend && currentTrigger && this._onceOnly ) {
if ( this.timelineData._playedTriggers.has( currentTrigger ) ) {
return null
}
this.timelineData._playedTriggers.add( currentTrigger )
}

this.timelineData._playedTriggers.add( currentTrigger )

// We have to empty the promises here because we are creating a new timeline.
// This is to prevent the promises from the previous timeline from affecting the new one.
this._funcPromises = {}
Expand Down