Skip to content

Add SubnetIDs field to support multiple subnets for machine instances #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
axel7born wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add SubnetIDs field to support multiple subnets for machine instances #347

axel7born wants to merge 2 commits into from

Conversation

@axel7born
Copy link

@axel7born axel7born commented Dec 19, 2025 •
edited
Loading

How to categorize this PR?

/area networking
/kind enhancement
/platform openstack

What this PR does / why we need it:
To enable dual-stack support for provider-openstack, servers require IPv6 addresses. This is accomplished by connecting servers to an IPv6 subnet. Consequently, configuring two subnets is necessary for dual-stack functionality.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

To support dual-stack networking, multiple subnets can be configured.
The field SubnetID in MachineProviderConfigSpec is now deprecated. Please use SubnetIDs instead. Support for SubnetID will be removed in a future release.

@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/networking Networking related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure needs/review Needs review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 19, 2025
@gardener-ci-robot
Copy link

gardener-ci-robot commented Jan 3, 2026

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-robot gardener-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2026
@axel7born
Copy link
Author

axel7born commented Jan 7, 2026

/remove-lifecycle stale

@gardener-robot
Copy link

gardener-robot commented Jan 7, 2026

@axel7born Command /remove-lifecycle is not known.

hebelsan
hebelsan reviewed Jan 7, 2026
View reviewed changes
pkg/apis/openstack/v1alpha1/types.go
// +optional
SubnetID *string `json:"subnetID,omitempty"`
// SubnetIDs is a list of IDs of the subnets the instance should belong to.
SubnetIDs []string `json:"subnetIDs,omitempty"`
Copy link
Contributor

@hebelsan hebelsan Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SubnetIDs is optional, right?
It would probably also make sense to mention that SubnetID and SubnetIDs are currently merged.

Also, the doc comment on SubnetID looks odd / unfinished.
Should we deprecate SubnetID and add a TODO noting its removal in, say, three releases?

Copy link
Author

@axel7born axel7born Jan 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SubnetIDs is optional, right? It would probably also make sense to mention that SubnetID and SubnetIDs are currently merged.

Yes, SubnetIDs is optional.

Also, the doc comment on SubnetID looks odd / unfinished. Should we deprecate SubnetID and add a TODO noting its removal in, say, three releases?

I deleted the the unfinished sentence. In provider-openstack SubnetID is always set. I have no idea what should happen if it's omitted.
I'm not sure about a deprecation. For me it would be fine, if we have both for some time.

Copy link
Contributor

@hebelsan hebelsan Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Just had a quick discussion with @kon-angelo about the deprecation.
If we add the comment (// Deprecated ...) for the SubnetID field now we can remove it in a future release and already switch to using the SubnetIDs field only in the provider extension.

@gardener-github-actions gardener-github-actions bot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 8, 2026
@axel7born axel7born marked this pull request as ready for review January 8, 2026 10:10
@axel7born axel7born requested review from a team as code owners January 8, 2026 10:10
@axel7born axel7born force-pushed the enh/multiple-subnets branch from 9714600 to 43fe861 Compare January 8, 2026 10:22
@axel7born axel7born force-pushed the enh/multiple-subnets branch from 43fe861 to 1d896b4 Compare January 8, 2026 13:42
@hebelsan
Copy link
Contributor

hebelsan commented Jan 8, 2026

@axel7born Can you please add a deprecation announcement in the release notes?

@aaronfern aaronfern removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hebelsan hebelsan hebelsan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/networking Networking related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/review Needs review needs/second-opinion Needs second review by someone else platform/openstack OpenStack platform/infrastructure reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@axel7born @gardener-ci-robot @gardener-robot @hebelsan @aaronfern