Skip to content

Dev v0.3 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
generationmake wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Dev v0.3 #11

generationmake wants to merge 14 commits into from

Conversation

@generationmake
Copy link
Owner

@generationmake generationmake commented Aug 24, 2023

next release

@generationmake generationmake self-assigned this Aug 24, 2023
@generationmake generationmake linked an issue Aug 24, 2023 that may be closed by this pull request
add pull down on SDO #8
Open
@generationmake generationmake linked an issue Aug 24, 2023 that may be closed by this pull request
add protection on CAN lines #7
Open
@generationmake
Copy link
Owner Author

generationmake commented Aug 27, 2023

Hi @aentinger
Any comments from your side?
Thanks

aentinger
aentinger approved these changes Aug 27, 2023
View reviewed changes
Copy link

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Only one question: what are the default configured mounting options for the 0R resistors for CS / INT? Are those the right options to work with a RPI4 out of the box?

@generationmake
Copy link
Owner Author

generationmake commented Aug 27, 2023

Hi @aentinger
There is no real default config. The raspbery pi supports SPI0 with two CS options. One is spi0-0 with CS on pin 24, the second is spi0-1 with CS on pin 26. There are also 4 possible interrupt pins.
My suggested default configuration is spi0-0 and interrupt=25. This is what is configured by the resistor jumpers.
dtoverlay=mcp251xfd,spi0-0,interrupt=25

@aentinger
Copy link

aentinger commented Aug 27, 2023

Check, sounds good to me ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aentinger aentinger aentinger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@generationmake generationmake

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add pull down on SDO add protection on CAN lines

3 participants

@generationmake @aentinger