fix: Additional tests optimization when running on github actions. #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
…-computing/mellea into fix/286-tests-cleanup
jakelorocco
reviewed
Jan 12, 2026
| hf_model_name="ibm-granite/granite-4.0-micro", | ||
| ollama_name="ibm/granite4:micro", | ||
| ollama_name="granite4:micro", | ||
| openai_name="granite4:micro", # setting this just for testing purposes. |
Contributor
There was a problem hiding this comment.
Since this is user facing, I don't think we should set this for testing purposes. We should just explicitly refer to .ollama_name when instantiating the backend/session.
test/conftest.py
Outdated
Comment on lines
26
to
70
| @pytest.fixture(autouse=True, scope="function") | ||
| def aggressive_cleanup(): | ||
| """Aggressive memory cleanup after each test to prevent OOM on CI runners.""" | ||
| yield | ||
| # Only run aggressive cleanup in CI where memory is constrained | ||
| if int(os.environ.get("CICD", 0)) != 1: | ||
| return | ||
|
|
||
| # Cleanup after each test | ||
| gc.collect() | ||
| gc.collect() | ||
|
|
||
| # If torch is available, clear CUDA cache | ||
| try: | ||
| import torch | ||
|
|
||
| if torch.cuda.is_available(): | ||
| torch.cuda.empty_cache() | ||
| torch.cuda.synchronize() | ||
| except ImportError: | ||
| pass | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True, scope="module") | ||
| def cleanup_module_fixtures(): | ||
| """Cleanup module-scoped fixtures to free memory between test modules.""" | ||
| yield | ||
| # Only run aggressive cleanup in CI where memory is constrained | ||
| if int(os.environ.get("CICD", 0)) != 1: | ||
| return | ||
|
|
||
| # Cleanup after module | ||
| gc.collect() | ||
| gc.collect() | ||
| gc.collect() | ||
|
|
||
| # If torch is available, clear CUDA cache | ||
| try: | ||
| import torch | ||
|
|
||
| if torch.cuda.is_available(): | ||
| torch.cuda.empty_cache() | ||
| torch.cuda.synchronize() | ||
| except ImportError: | ||
| pass |
Contributor
There was a problem hiding this comment.
Can we extract this logic into a single function and then just create two pytest fixtures that call it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will hope to fix #286 with some additional inputs from @jakelorocco. For now, it:
conftest.pyqualitative