Skip to content

PR: fix race condition bug when timeout is None in 'qtwait' function #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnsebgosselin merged 1 commit into from
Oct 6, 2025
Merged

PR: fix race condition bug when timeout is None in 'qtwait' function #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion qtapputils/qthelpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,11 +372,17 @@ def qtwait(condition, timeout=None, check_interval=50, error_message=None):
loop = QEventLoop()
start_time = time.monotonic()

timed_out = [False]
# We use a mutable container for 'timed_out' so the inner check_condition()
# can update the value in the enclosing scope (works for nested functions
# without using the 'nonlocal' keyword).

def check_condition():
elapsed_time = time.monotonic() - start_time
if condition():
loop.quit()
elif timeout is not None and elapsed_time >= timeout:
timed_out[0] = True
loop.quit()

timer = QTimer()
Expand All @@ -386,6 +392,7 @@ def check_condition():
check_condition()
loop.exec_()

if not condition():
# Only raise TimeoutError if timeout was specified and reached.
if timeout is not None and timed_out[0] and not condition():
raise TimeoutError(
error_message or "Condition not met within timeout.")