-
Notifications
You must be signed in to change notification settings - Fork 83
feat: standalone lightning address support #1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@matjaz thanks for the PR. However, I am not sure LNURL fits well in the hub:
I think it seems better to keep it separate (such as the service you implemented, or Alby Lite). Also it's already been merged that you can now create getalby.com lightning addresses for sub-wallets. |
|
Hey, that's all correct, however it's a perfect fit for public self-hosted hub with custom domain, not requiring additional app. |
|
@matjaz I asked the team. Although it is a nice idea, this will not work for the majority of users and we already have a solution that works no matter what way you run Alby Hub. The getalby.com sub-wallet lightning addresses do require a relay, but they use the getalby.com relay which we spend a lot of time to make it reliable. Lightning addresses are a core feature of the Alby Account. We will ensure that they work reliably. I will mark this as a draft for now, but please feel free to maintain a fork and if anyone who self-hosts on a VPS asks for this feature I will let them know you have implemented this. |
Add GetBaseFrontendUrl() to remove duplication (getAlby#1506)
For standalone HTTP instance add support for Lightning addresses.
Currently username is app_pubkey, but custom username would be better option.
Supported are following: