QuickStart Apps - Android Tasks app by kristopherjohnson · Pull Request #1 · getditto/quickstart

kristopherjohnson · 2024-11-04T14:54:49Z

Create a new Jetpack Compose app in Android Studio Koala with current versions of the Android SDK and all dependencies. The minimum supported SDK version will be 23, which is the oldest version supported by Ditto.
Copy the screen layouts and code from https://github.com/getditto/template-app-jetpack-compose-kotlin-todo, which is already pretty close to what we want for our final app.
Update the app’s data model to match the specifications in QuickStart Apps: Task App data model
Update the UI to match the design specifications in Docs Quickstart & Install Guides

For more details, see QuickStart Apps Android Task App Development Notes

…to the project

…apt to newer dependencies

…ll list items are visible

…n.so/getditto/KB-Device-Permissions-Needed-by-Transports-10d9d9829a3280f89647f16252af1fe0

…ch task row in the tasks list

S4H

I'll have to defer to @phatblat to review the android app as that is outside of my wheelhouse but I was able to easily follow the readme and build the application without issue so can say it passes the dummies check :)

android/README.md

S4H · 2024-11-18T14:50:11Z

android/README.md

+
+### Adding the Ditto SDK
+
+At the bottom of `app/build.gradle.kts`, you will see this line that causes Android Studio to automatically download the Ditto SDK from Maven Central and add it to the project:


can we run a formatter on this file? It's a little jarring having inconsistant line lengths.

I'm not sure we can. Different Markdown processors handle list items differently, and adding newlines to break them into shorter lines might not be handled consistently. I think GitHub-flavored Markdown has changed the way it handles newlines more than once.

I've fixed the line wrapping on a couple of paragraphs.

phatblat · 2024-11-18T20:37:16Z

...id/QuickStartTasks/app/src/main/java/live/ditto/quickstart/tasks/edit/EditScreenViewModel.kt

+        viewModelScope.launch {
+            try {
+                val item = ditto.store.execute(
+                    "SELECT * FROM tasks WHERE _id = :_id",


Should this DQL query include NOT deleted or deleted != true in the WHERE clause?

It would only matter if another device deletes the task between the time a user taps the Edit button and the Edit Task screen appears, in which case the user will be editing a just-deleted task. When they tap Save, the task's properties will be edited, but will also be deleted.

But I agree we should include the WHERE clause for correctness.

phatblat · 2024-11-18T20:52:04Z

android/QuickStartTasks/app/build.gradle.kts

+androidComponents {
+    onVariants {


I haven't used this type of config before but it looks like a good way to reduce duplication when you're using the same properties in every build variant.

phatblat · 2024-11-18T20:54:42Z

android/QuickStartTasks/app/build.gradle.kts

+        compose = true
+    }
+    composeOptions {
+        kotlinCompilerExtensionVersion = "1.5.14"


Not something that needs to be done in this PR, but since the kotlin compiler version will need to change with the kotlin dependencies, this would be a good value to extract into the version catalog. There are several examples in the Ditto Kotlin SDK of using the version catalog for arbitrary version numbers:

https://github.com/getditto/ditto/blob/ba44fb0f182fe5274f976d0462ec7cfef421916f/android/ditto/build.gradle.kts#L32-L33
https://github.com/getditto/ditto/blob/ba44fb0f182fe5274f976d0462ec7cfef421916f/android/gradle/libs.versions.toml#L23-L28

I'll review that. I actually had a few problems with getting a compatible set of versions of the Kotlin compiler, gradle, Android compileSdk setting, and other tools, so I've probably overlooked an easy way to keep them in sync.

phatblat · 2024-11-18T20:55:15Z

...ickStartTasks/app/src/main/java/live/ditto/quickstart/tasks/list/TasksListScreenViewModel.kt

+        viewModelScope.launch {
+            try {
+                val doc = ditto.store.execute(
+                    "SELECT * FROM tasks WHERE _id = :_id",


Does this query need to filter out deleted tasks?

Yes, it should. However, similar to the earlier case, the task would only be displayed in the UI if it is not deleted, so this would only matter if another device deletes it during the interval between the last observer notification and the app responding to the toggle click.

phatblat · 2024-11-18T20:56:21Z

Everything looks great in this PR. I left a couple comments and minor questions.

…es, to avoid changes to deleted items

kristopherjohnson added 2 commits November 1, 2024 14:24

Create new Kotlin Jetpack Compose app project, and add the Ditto SDK …

d1932fb

…to the project

Copy code and resources from template-app-jetpack-compose-todo and ad…

ffe8022

…apt to newer dependencies

kristopherjohnson self-assigned this Nov 4, 2024

kristopherjohnson changed the title ~~QuickStart Android Tasks app~~ QuickStart Apps - Android Tasks app Nov 4, 2024

kristopherjohnson added 13 commits November 4, 2024 15:35

Correctly handle the Material 3 Scaffold padding parameter, so that a…

af47e49

…ll list items are visible

Update data model

203f30f

Add App ID, Token, and Sync enabled elements to task list top bar

628c57b

Get Ditto app ID and authentication token from BuildConfig

2339fd4

Get DITTO_APP_ID and DITTO_PLAYGROUND_TOKEN values from .env file

3f7a427

Update Android permissions according to advice from https://www.notio…

3c3a16e

…n.so/getditto/KB-Device-Permissions-Needed-by-Transports-10d9d9829a3280f89647f16252af1fe0

Implement Sync Enabled switch

24043b6

Use material3.ListItem instead of Row for task list rows

3affe44

Add Edit (pencil) and Delete (trashcan) icons to the right side of ea…

fbbaaa3

…ch task row in the tasks list

Add details to android/README.md

9c02151

Implement the functionality of the Sync Enabled switch

bba48a0

Add initial collection of tasks

83055af

Improve exception logging

6cd234b

kristopherjohnson requested review from S4H, nicholastmosher and phatblat November 15, 2024 18:43

kristopherjohnson marked this pull request as ready for review November 15, 2024 18:44

S4H reviewed Nov 18, 2024

View reviewed changes

Fix line wrapping for long paragraph lines

5cf3b75

phatblat reviewed Nov 18, 2024

View reviewed changes

phatblat approved these changes Nov 18, 2024

View reviewed changes

Include "AND NOT deleted" in DQL statements that modify task properti…

4d15af3

…es, to avoid changes to deleted items

kristopherjohnson merged commit 5f77aec into main Nov 18, 2024

kristopherjohnson deleted the kj/quickstart-android branch November 18, 2024 21:09


		### Adding the Ditto SDK

		At the bottom of `app/build.gradle.kts`, you will see this line that causes Android Studio to automatically download the Ditto SDK from Maven Central and add it to the project:

		androidComponents {
		onVariants {

Comments

Conversation

kristopherjohnson commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

S4H left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phatblat Nov 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phatblat commented Nov 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kristopherjohnson commented Nov 4, 2024 •

edited

Loading

phatblat Nov 18, 2024 •

edited

Loading