Conversation
pvditto
changed the title
This reverts commit 9a0cd30.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up GitHub Actions workflow files by removing empty with: blocks and standardizing YAML formatting. The changes improve code consistency without altering workflow functionality.
- Removed unnecessary empty
with:blocks from action invocations across multiple CI workflows - Standardized quote style from single quotes to double quotes for YAML string values
- Fixed indentation and removed extraneous blank lines
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/swift-ci.yml | Removed empty with: block from generate-browserstack-names action |
| .github/workflows/java-spring-ci.yml | Removed empty with: block, standardized quotes to double quotes, fixed indentation, and removed extra blank lines |
| .github/workflows/android-kotlin-ci.yml | Removed empty with: block from generate-browserstack-names action |
| .github/workflows/android-java-ci.yml | Removed empty with: block, standardized quotes to double quotes, and fixed indentation |
| .github/workflows/android-cpp-ci.yml | Removed empty with: block from generate-browserstack-names action |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
teodorciuraru
approved these changes
Oct 31, 2025
pvditto
deleted the
pv/sdks-2001-quickstart-swift-integration-testing-broken-due-to-syntax
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves syntax errors in integration test workflows for:
Also, adds a new check that fails if any workflows have syntax errors.edit: I tried adding a linter for the workflows but there were so many warnings, especially from shellcheck on inline scripts, that should be its own task