-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: queue time metric #16030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: queue time metric #16030
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| config.capture_queue_time = false | ||
| ``` | ||
|
|
||
| **Nginx:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you link to tracing/instrumentation/performance-metrics/#automatic-queue-time-capture here and remove the nginx/haproxy blocks?
|
|
||
| Automatically capture how long requests wait in the web server queue before processing begins. The SDK reads the `X-Request-Start` header set by reverse proxies (Nginx, HAProxy, Heroku) and attaches queue time to transactions as `http.queue_time_ms`. | ||
|
|
||
| This helps identify when requests are delayed due to insufficient worker threads or server capacity, which is especially useful under load. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This helps identify when requests are delayed due to insufficient worker threads or server capacity, which is especially useful under load. | |
| This helps identify when requests are delayed due to insufficient worker threads or server capacity, which is especially useful under high load. |
coolguyzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for updating! 🏄♂️
DESCRIBE YOUR PR
docs for Ruby queue-time capture getsentry/sentry-ruby#2838
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES