fix: Sidebar scroll position jumping on navigation#16416
Merged
stephanie-anderson merged 1 commit intomasterfrom Feb 17, 2026
Merged
fix: Sidebar scroll position jumping on navigation#16416stephanie-anderson merged 1 commit intomasterfrom
stephanie-anderson merged 1 commit intomasterfrom
Conversation
The sidebar scroll position was not preserved when navigating between pages, especially in the develop-docs sidebar. Three issues fixed: 1. Add missing ScrollActiveLink to DevelopDocsSidebar (was only in product sidebar) 2. Fix click handler using hasAttribute instead of closest(), which never fired because click targets are child elements inside the link 3. Store scrollContainer.scrollTop directly instead of fragile getBoundingClientRect math, and remove scroll handler that was overwriting click data with stale active link positions Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
coolguyzone
approved these changes
Feb 17, 2026
Contributor
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Changes look good, behavior looks good on preview, seeing expected changes in sessionStorage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sidebar scroll position not being preserved when navigating between pages. Particularly noticeable on smaller screens (e.g. MacBook Pro 14") when navigating within a section like
/development-infrastructure/.Three bugs fixed:
target.hasAttribute('data-sidebar-link')but click targets are always child<span>/<div>elements inside the link; fixed to usetarget.closest()getBoundingClientRectmath with directscrollContainer.scrollTopsave/restore, and removed a scroll handler that was overwriting click data with stale positionsCo-Authored-By: Claude noreply@anthropic.com