Skip to content

fix(bun) Export pinoIntegration from @sentry/node #17990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreiborza merged 3 commits into from
Feb 18, 2026
+1 −0
Merged

fix(bun) Export pinoIntegration from @sentry/node #17990

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25f53d9
fix(bun) Export pinoIntegration from @sentry/node
LudvigHz Oct 21, 2025
5a8c0b7
Merge branch 'develop' into pinointegration-bun
timfish Feb 17, 2026
8f71476
Merge branch 'develop' into pinointegration-bun
andreiborza Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/bun/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ export {
consoleLoggingIntegration,
createConsolaReporter,
createSentryWinstonTransport,
pinoIntegration,
Copy link

@sentry sentry bot Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The PR exports pinoIntegration for Bun, but a test file marks it as unsupported. This will cause CI failure and likely runtime errors due to missing runtime APIs.
Severity: HIGH

Suggested Fix

Either remove the pinoIntegration export from packages/bun/src/index.ts if it is indeed unsupported by Bun, or, if it is now supported, remove pinoIntegration from the ignoreExports array in dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts and provide evidence that the underlying diagnosticsChannel API works correctly in Bun.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: packages/bun/src/index.ts#L169

Potential issue: The pull request adds `pinoIntegration` to the `@sentry/bun` package
exports. However, the test file `consistentExports.ts` still lists `pinoIntegration` in
its `ignoreExports` array with a comment stating it is "not supported in bun". This will
cause the `consistentExports` CI test to fail. More critically, the `pinoIntegration`
relies on the Node.js `diagnosticsChannel` API, which is likely unsupported in the Bun
runtime. Exporting this integration without verifying its compatibility will lead to a
broken feature that causes runtime errors for any user who attempts to use it.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link

@cursor cursor bot Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale ignoreExports entry undermines test coverage for new export

Medium Severity

pinoIntegration is now exported from @sentry/bun, but consistentExports.ts still lists it in ignoreExports with the comment "not supported in bun." This means the consistency check skips verifying this export exists, so if someone accidentally removes it later, no test will catch the regression. The ignoreExports entry needs to be removed to get proper test coverage. Additionally, this is a fix PR with no test that actually validates the fix — updating consistentExports.ts would serve as that regression test.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

wrapMcpServerWithSentry,
featureFlagsIntegration,
launchDarklyIntegration,
Expand Down
Loading