feat(openai-agents): Set system instruction attribute #5355
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "type": "text", | ||
| "content": system_instructions, | ||
| } | ||
| ] |
There was a problem hiding this comment.
System instruction format uses wrong key name
Medium Severity
The _transform_system_instruction function and TextPart TypedDict use "content" as the dictionary key, but the OpenTelemetry semantic conventions and the rest of the codebase use "text". The docstring example for GEN_AI_SYSTEM_INSTRUCTIONS shows {"type": "text", "text": "..."}, and existing code in utils.py, anthropic.py, and langchain.py all use the "text" key. This inconsistency means the telemetry data won't conform to the OTel structure as intended by the PR.
Additional Locations (1)
There was a problem hiding this comment.
um check the link in the PR description.
Description
Set the system instruction attribute, conforming to OTtel structure:
https://opentelemetry.io/docs/specs/semconv/registry/attributes/gen-ai/#gen-ai-system-instructions
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)