feat(langchain): Set system instruction attribute #5357
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "type": "text", | ||
| "content": instruction.content, | ||
| } | ||
| for instruction in system_instructions |
There was a problem hiding this comment.
System instructions field uses wrong key name
Medium Severity
The _transform_system_instructions function creates dictionaries with "content" as the key, but the docstring example in consts.py and other integrations (anthropic, pydantic_ai) consistently use "text" as the key for text parts. The docstring shows {"type": "text", "text": "You are a helpful assistant."} but the implementation produces {"type": "text", "content": "..."}. This inconsistency will cause the langchain integration to produce data in a different format than other integrations and what's documented.
Description
Set the system instruction attribute, conforming to OTtel structure:
https://opentelemetry.io/docs/specs/semconv/registry/attributes/gen-ai/#gen-ai-system-instructions
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)