test(fastmcp): Use AsyncClient for SSE
#5400
Merged
+263
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Span Streaming
Bug Fixes 🐛Span Streaming
Other
Internal Changes 🔧Fastmcp
Mcp
Other
🤖 This preview updates automatically when you update the PR. |
alexander-alderman-webb
changed the title
AsyncClient for SSE
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 4.64s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 13719 uncovered lines. Files with missing lines (180)
Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| if request.content: | ||
| request_body = await request.aread() | ||
|
|
||
| body_sender, body_receiver = create_memory_object_stream[bytes](0) # type: ignore |
There was a problem hiding this comment.
Bug: The test fixture json_rpc_sse uses create_memory_object_stream[bytes](0), which is AnyIO 4.0+ syntax. However, tox.ini constrains test environments to AnyIO < 4.0, causing a TypeError.
Severity: HIGH
Suggested Fix
Revert the call at tests/conftest.py:842 to use the AnyIO 3.x compatible syntax: create_memory_object_stream(0). This will align the code with the version constraints specified in tox.ini and ensure the tests can run successfully in the configured environments.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: tests/conftest.py#L842
Potential issue: The code at `tests/conftest.py:842` uses
`create_memory_object_stream[bytes](0)`, a syntax valid only for AnyIO version 4.0 and
later. However, the project's `tox.ini` configuration explicitly pins AnyIO to versions
below 4.0.0 for several test environments, including `fastapi` and `starlette`. When
tests are executed in these environments, an older version of AnyIO will be installed.
This will cause a `TypeError: 'function' object is not subscriptable` at runtime because
the AnyIO 3.x version of `create_memory_object_stream` does not support subscripting.
This will cause tests that rely on the `json_rpc_sse` fixture to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stop mocking transport layer of
mcppackage in tests.The SSE server and client are run in-process by using an in-memory object queue to pass messages.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)