-
Notifications
You must be signed in to change notification settings - Fork 580
test(fastmcp): Wrap prompt in Message
#5411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Span Streaming
Bug Fixes 🐛Span Streaming
Other
Internal Changes 🔧Fastmcp
Mcp
Other
🤖 This preview updates automatically when you update the PR. |
Message
Codecov Results 📊✅ 118 passed | Total: 118 | Pass Rate: 100% | Execution Time: 18.05s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 13162 uncovered lines. Files with missing lines (179)
Generated by Codecov Action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
sentrivana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏🏻
Description
The following error is returned from
result.json()without the change:I haven't investigated this in much depth, but Cursor fetched me this from the upgrade guide 😄
https://github.com/jlowin/fastmcp/blob/main/docs/development/upgrade-guide.mdx#prompts-use-message-class
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)