Skip to content

Conversation

@ericapisani
Copy link
Member

Description

Under the hood within Kombu (the messaging library used by Celery), the driver_type is ultimately derived from the broker's URL that's provided in the Celery configuration by the user via either the broker or broker_url arguments.

We can accomplish the same thing in our context, removing the need to open a connection to the broker to determine the driver_type to set in the span.

The broker_url is set in both of the following scenarios:

  • app = Celery("tasks", broker_url=<your-broker-url>)
  • app = Celery("tasks", broker=<your-broker-url>)

Issues

Under the hood within Kombu (the messaging library used by Celery),
the `driver_type` is ultimately derived from the broker's URL that's
provided in the Celery configuration by the user via either the
`broker` or `broker_url` arguments.

We can accomplish the same thing in our context, removing the need to
open a connection to the broker to determine the `driver_type` to
set in the span.

Fixes PY-2071
Fixes getsentry#5428
@github-actions
Copy link
Contributor

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

Celery

  • Get transport's driver_type from broker's URL by ericapisani in #5456
  • Close the connection we're reading driver_type from by sentrivana in #5427

Documentation 📚

  • Document openai-agents control-flow by alexander-alderman-webb in #5447

Internal Changes 🔧

  • (ci) Improve Craft config with title stripping and artifact filtering by BYK in #5444
  • (openai-agents) Avoid calling SDK-internal functions by alexander-alderman-webb in #5437
  • Remove references to unsupported attribute types by alexander-alderman-webb in #5425
  • Pin setuptools for linting and chalice tests by alexander-alderman-webb in #5438

🤖 This preview updates automatically when you update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get driver_type from elsewhere in Celery tasks

1 participant