Closed
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 118 passed | Total: 118 | Pass Rate: 100% | Execution Time: 18.08s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 13173 uncovered lines. Files with missing lines (179)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 25.71% 33.45% +7.74%
==========================================
Files 189 189 —
Lines 19795 19795 —
Branches 6408 6408 —
==========================================
+ Hits 5090 6622 +1532
- Misses 14705 13173 -1532
- Partials 431 646 +215Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| repo: context.repo.repo, | ||
| pull_number: pr.number, | ||
| state: 'open' | ||
| }); |
There was a problem hiding this comment.
Close/reopen with GITHUB_TOKEN won't trigger CI
High Severity
The close/reopen workaround won't actually trigger CI workflows. GitHub prevents all events generated by GITHUB_TOKEN from triggering subsequent workflows — not just PR creation. Since this workflow authenticates with the default GITHUB_TOKEN (line 28), the close and reopen API calls are also attributed to GITHUB_TOKEN, so no pull_request event fires. A Personal Access Token or GitHub App installation token is needed instead.
| COMMIT_TITLE="ci: 🤖 Update test matrix with new releases" | ||
| DATE=`date +%m/%d` | ||
| BRANCH_NAME="toxgen/update" | ||
| BRANCH_NAME="toxgen/update-$(date +%m-%d)" |
There was a problem hiding this comment.
Date-based branch breaks old PR cleanup logic
Medium Severity
Changing BRANCH_NAME from a static toxgen/update to a date-based toxgen/update-$(date +%m-%d) breaks the existing PR cleanup logic. The cleanup query filters by head: owner:branchName, so it only finds PRs matching the current week's branch name. PRs from previous weeks (e.g., toxgen/update-02-12) will never match toxgen/update-02-19 and will accumulate as unclosed open PRs.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, CI is not run on toxgen PRs. Try whether closing and opening the PR would do the trick.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)