Open
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Documentation 📚
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 7.25s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 13698 uncovered lines. Files with missing lines (180)
Generated by Codecov Action |
ericapisani
reviewed
Feb 18, 2026
ericapisani
reviewed
Feb 18, 2026
dingsdax
reviewed
Feb 19, 2026
| 3. Ensure that the **semantics** of the attribute are clear. If the attribute is not uniquely defined, do not add it. | ||
| - For instance, do not attach a request model to an agent invocation span. On the other hand, a default request model can be well-defined. | ||
|
|
||
| ### Code |
Contributor
There was a problem hiding this comment.
This section it very dense. It will improve scan-ability if you either mark the number list points bold or make it a heading (H4).
dingsdax
reviewed
Feb 19, 2026
Contributor
dingsdax
left a comment
dingsdax
left a comment
There was a problem hiding this comment.
Some phrasing feels emotionally charged or too sarcastic imho:
- So this means you should write the ugly code in the library to work around this?
- Oh, and did I mention that bugs in old SDK versions can still come to haunt you?
- This means that the SDK is not a playground for the inappropriate use of AI-assisted coding.
- and Python has duck-typing, so good luck.
- ... saves as a headache
contributing guide should not sound adversarial, please change tone, it can still be strong but less combatitive
dingsdax
reviewed
Feb 19, 2026
Contributor
dingsdax
left a comment
dingsdax
left a comment
There was a problem hiding this comment.
SDK Contract Section & the obsessing about the unhappy path is ❤️ very good!
sentrivana
reviewed
Feb 19, 2026
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
This is great, thank you for adding. ❤️ Left some comments and suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add guidance for writing integrations based on my observations over the last 6 months in the team.
Issues
Closes #5177
Reminders
tox -e linters.feat:,fix:,ref:,meta:)