fix(anthropic): fix token accounting#5490
Merged
Conversation
obostjancic
approved these changes
Feb 20, 2026
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 7.79s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 13701 uncovered lines. Files with missing lines (180)
Generated by Codecov Action |
Comment on lines
+111
to
+114
| # Anthropic's input_tokens excludes cached/cache_write tokens. | ||
| # Normalize to total input tokens so downstream cost calculations | ||
| # (input_tokens - cached) don't produce negative values. | ||
| input_tokens += cache_read_input_tokens + cache_write_input_tokens |
Contributor
There was a problem hiding this comment.
you're already adding cache read and write outside afterwards, can remove this.
Member
Author
There was a problem hiding this comment.
No I don't think we can remove this - there are two codepaths below, one of them for non-streaming and one for streaming. The streaming one does not use this function to retrieve the cost, so it needs to normalize separately
alexander-alderman-webb
requested changes
Feb 20, 2026
Contributor
alexander-alderman-webb
left a comment
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
I would expect existing tests to change, can you please verify why they still pass even though the behavior has changed @shellmayr 🙏
alexander-alderman-webb
approved these changes
Feb 20, 2026
Contributor
alexander-alderman-webb
left a comment
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
ah it's fine the tests aren't great.
Member
Author
|
@alexander-alderman-webb had a look at the tests - they didn't assert on the total tokens, etc, only the cache tokens. adapted them so they would have failed, as a regression test going forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.