feat: v7: Capture app start errors before JS #5470
Draft
+4,777
−1,020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructures (#4445) * Extract Android SDK Init * Update tests * Adds changelog * Fix lint issues * Rename RNSentryStart instance for clarity * Converts RNSentryStart to utility class * Update CHANGELOG.md --------- Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
* Convert json object to writable map * Make class/methods package-private(default)
- Resolved merge conflicts across iOS, Android, and JavaScript/TypeScript code - Updated iOS implementation to use RNSentryStart API - Fixed Android compilation errors for Sentry Android SDK v7 compatibility - Removed deprecated API calls (setEnableTracing, getPackages, getIntegrations) - Updated Gradle build scripts and resolved conflict markers - All builds verified: iOS, Android, and Expo sample apps compile successfully
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7b02433+dirty | 492.61 ms | 529.04 ms | 36.43 ms |
| fa7bb7e+dirty | 285.22 ms | 323.44 ms | 38.22 ms |
| 6a70a7e+dirty | 382.45 ms | 424.54 ms | 42.09 ms |
| 86584b7+dirty | 367.98 ms | 374.12 ms | 6.14 ms |
| d081295+dirty | 416.95 ms | 461.24 ms | 44.29 ms |
| 8d89cc9+dirty | 357.69 ms | 415.79 ms | 58.10 ms |
| e07935d+dirty | 380.10 ms | 377.48 ms | -2.62 ms |
| 1e7a472+dirty | 319.58 ms | 372.29 ms | 52.71 ms |
| c9e95bd+dirty | 339.32 ms | 401.24 ms | 61.92 ms |
| 266bc7e+dirty | 378.00 ms | 392.81 ms | 14.81 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7b02433+dirty | 43.94 MiB | 49.38 MiB | 5.44 MiB |
| fa7bb7e+dirty | 7.15 MiB | 8.46 MiB | 1.31 MiB |
| 6a70a7e+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 86584b7+dirty | 43.94 MiB | 48.91 MiB | 4.97 MiB |
| d081295+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| 8d89cc9+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| e07935d+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
| 1e7a472+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| c9e95bd+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 266bc7e+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
Previous results on branch: capture-app-start-errors-v7
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f26d7a8+dirty | 380.15 ms | 407.84 ms | 27.68 ms |
| 99179a4+dirty | 357.38 ms | 375.64 ms | 18.26 ms |
| 60d1e83+dirty | 406.16 ms | 422.83 ms | 16.67 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f26d7a8+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
| 99179a4+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
| 60d1e83+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
The file is in the parent directory, so use ../ prefix to fix the import path
The property is deprecated in v7. Tracing is already disabled by setting tracesSampleRate and tracesSampler to nil.
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5691430+dirty | 1218.89 ms | 1222.22 ms | 3.33 ms |
| 90afdd3+dirty | 1233.90 ms | 1240.90 ms | 7.00 ms |
| 180638b+dirty | 1221.90 ms | 1220.40 ms | -1.51 ms |
| 2adbd1e+dirty | 1207.51 ms | 1218.98 ms | 11.47 ms |
| ee69ed5+dirty | 1206.79 ms | 1213.98 ms | 7.19 ms |
| eb07ba3+dirty | 1222.46 ms | 1220.37 ms | -2.08 ms |
| 8a4ce6f+dirty | 1221.31 ms | 1219.84 ms | -1.47 ms |
| 818a608+dirty | 1205.76 ms | 1208.00 ms | 2.24 ms |
| b7aa1aa+dirty | 1234.35 ms | 1241.61 ms | 7.27 ms |
| 1ef8a04+dirty | 1226.14 ms | 1223.15 ms | -2.99 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5691430+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 90afdd3+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
| 180638b+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
| 2adbd1e+dirty | 2.63 MiB | 4.00 MiB | 1.36 MiB |
| ee69ed5+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| eb07ba3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 8a4ce6f+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| 818a608+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| b7aa1aa+dirty | 2.63 MiB | 4.01 MiB | 1.38 MiB |
| 1ef8a04+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
Previous results on branch: capture-app-start-errors-v7
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 60d1e83+dirty | 1207.79 ms | 1207.35 ms | -0.44 ms |
| 99179a4+dirty | 1213.96 ms | 1215.34 ms | 1.38 ms |
| f26d7a8+dirty | 1209.49 ms | 1207.54 ms | -1.95 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 60d1e83+dirty | 3.41 MiB | 4.67 MiB | 1.26 MiB |
| 99179a4+dirty | 3.44 MiB | 4.67 MiB | 1.23 MiB |
| f26d7a8+dirty | 3.44 MiB | 4.67 MiB | 1.23 MiB |
The enableTracing property is deprecated in Sentry Cocoa SDK v7. Tracing is already verified to be disabled by checking that tracesSampleRate and tracesSampler are nil.
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5691430+dirty | 1191.06 ms | 1189.13 ms | -1.94 ms |
| 90afdd3+dirty | 1216.17 ms | 1225.55 ms | 9.38 ms |
| 180638b+dirty | 1224.70 ms | 1223.71 ms | -0.99 ms |
| 2adbd1e+dirty | 1220.65 ms | 1230.20 ms | 9.56 ms |
| ee69ed5+dirty | 1212.78 ms | 1214.91 ms | 2.13 ms |
| eb07ba3+dirty | 1214.49 ms | 1221.59 ms | 7.10 ms |
| 8a4ce6f+dirty | 1232.80 ms | 1223.80 ms | -9.00 ms |
| 818a608+dirty | 1218.84 ms | 1223.18 ms | 4.34 ms |
| b7aa1aa+dirty | 1232.55 ms | 1234.16 ms | 1.61 ms |
| 1ef8a04+dirty | 1184.42 ms | 1186.44 ms | 2.02 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5691430+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 90afdd3+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
| 180638b+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
| 2adbd1e+dirty | 3.19 MiB | 4.56 MiB | 1.38 MiB |
| ee69ed5+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| eb07ba3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 8a4ce6f+dirty | 3.19 MiB | 4.53 MiB | 1.34 MiB |
| 818a608+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| b7aa1aa+dirty | 3.19 MiB | 4.58 MiB | 1.39 MiB |
| 1ef8a04+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
Previous results on branch: capture-app-start-errors-v7
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 60d1e83+dirty | 1201.87 ms | 1204.61 ms | 2.74 ms |
| 99179a4+dirty | 1210.16 ms | 1213.57 ms | 3.40 ms |
| f26d7a8+dirty | 1227.33 ms | 1220.67 ms | -6.66 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 60d1e83+dirty | 3.41 MiB | 4.67 MiB | 1.26 MiB |
| 99179a4+dirty | 3.44 MiB | 4.67 MiB | 1.23 MiB |
| f26d7a8+dirty | 3.44 MiB | 4.67 MiB | 1.23 MiB |
10 tasks
# Conflicts: # packages/core/android/libs/replay-stubs.jar # samples/react-native/android/app/build.gradle
10 tasks
* chore(sample-e2e): Migrate from Detox to Maestro * fix set dsn script path * fix: Update script paths after detox-to-maestro migration The set-dsn scripts were moved from scripts/detox/ to scripts/ during the migration * Update script paths * Fix tests * Fix test failure * Fix idle issue * fix(e2e): Fix Maestro flows for captureMessage and captureSpaceflightNewsScreen - Add scrollUntilVisible for 'Capture message' button (might be off-screen) - Add proper waiting and scrolling for SpaceflightNewsScreen to trigger auto-load - Wait for 'Load More Articles' button to appear after autoLoadCount threshold * chore(e2e-sample): Increase Maestro driver startup timeout (cherry picked from commit ee429b5) * increase timeout * Increase timeouts on Android too --------- Co-authored-by: Krystof Woldrich <krystof.woldrich@sentry.io>
Draft
# Conflicts: # packages/core/android/libs/replay-stubs.jar
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
10 tasks
…ch (#5544) * chore: Merge Android UI profiling on the capture startup crashes branch * Fix logger compilation issue * Properly check logging values
# Conflicts: # packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java # samples/react-native/android/app/build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR merges
main(v7) oncapture-app-start-errors(#4472) and handles:💡 Motivation and Context
Bring #4472 up to date with the latest
main💚 How did you test it?
CI, Manual
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog