Skip to content

chore(deps): bump getsentry/craft from 2.18.3 to 2.19.0 #5551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 1 commit into from
Jan 19, 2026
Merged

chore(deps): bump getsentry/craft from 2.18.3 to 2.19.0 #5551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
cache-dependency-path: yarn.lock

- name: Prepare release
uses: getsentry/craft@1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce # v2
uses: getsentry/craft@c6e2f04939b6ee67030588afbb5af76b127d8203 # v2
Copy link

@sentry sentry bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Upgrading getsentry/craft may break the release process. The craft-pre-release.sh script expects a positional argument that the new version of the action might no longer provide.
Severity: HIGH

Suggested Fix

Verify the invocation signature for preReleaseCommand in the new version of getsentry/craft. If the positional argument is no longer passed, update craft-pre-release.sh to retrieve the version from an environment variable or another source, or modify the script to handle a missing argument gracefully.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/release.yml#L46

Potential issue: The `release.yml` workflow upgrades the `getsentry/craft` action to a
new version. The release notes for this new version suggest that the `NEW-VERSION`
argument is now optional. The `craft-pre-release.sh` script, which is executed by this
action, expects the version to be passed as the second positional argument (`$2`). The
script also uses `set -u`, which will cause it to exit with an error if an unset
variable is referenced. If the upgraded `craft` action no longer passes this positional
argument, the release script will fail, breaking the release process.

Did we get this right? 👍 / 👎 to inform future reviews.

env:
GITHUB_TOKEN: ${{ steps.token.outputs.token }}
with:
Expand Down
Loading