-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(replay): guard replay endpoints with granular user permissions #104452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
shellmayr
wants to merge
15
commits into
shellmayr/feat/add-model-for-granular-replay-access
Choose a base branch
from
shellmayr/feat/guard-api-endpoints-by-granular-replay-access
base: shellmayr/feat/add-model-for-granular-replay-access
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(replay): guard replay endpoints with granular user permissions #104452
shellmayr
wants to merge
15
commits into
shellmayr/feat/add-model-for-granular-replay-access
from
shellmayr/feat/guard-api-endpoints-by-granular-replay-access
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## shellmayr/feat/add-model-for-granular-replay-access #104452 +/- ##
=====================================================================================
Coverage 80.53% 80.53%
=====================================================================================
Files 9336 9339 +3
Lines 401206 401273 +67
Branches 25744 25744
=====================================================================================
+ Hits 323105 323167 +62
- Misses 77659 77664 +5
Partials 442 442 |
f5a1fb6 to
af243b7
Compare
53748c7 to
ce468ae
Compare
f8575a5 to
4b786f2
Compare
6938277 to
fdc6279
Compare
4b786f2 to
b47d6d4
Compare
3c54328 to
d913c80
Compare
fcb6ffc to
757f936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrganizationReplayEndpointandProjectReplayEndpointto centralize feature and permission checks for replay access, ensuring consistent enforcement across all replay endpoints.Closes TET-1564