ref(ui): deprecate useProjects() without slugs #104462

dcramer · 2025-12-05T18:27:27Z

Add a development-time console warning when useProjects() is called without the slugs parameter. This prepares for removing the all_projects=1 bootstrap fetch by encouraging explicit project fetching.

Updates 18 components to pass specific slugs to useProjects(), ensuring they will continue working when projects are no longer pre-loaded.

Refs #104436

static/app/views/issueDetails/groupDetails.tsx

static/app/views/performance/newTraceDetails/traceDrawer/details/missingInstrumentation.tsx

codecov · 2025-12-05T18:36:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #104462   +/-   ##
========================================
  Coverage   80.51%    80.51%           
========================================
  Files        9348      9348           
  Lines      399919    399892   -27     
  Branches    25651     25648    -3     
========================================
- Hits       322005    321990   -15     
+ Misses      77466     77454   -12     
  Partials      448       448

dcramer · 2025-12-05T18:29:43Z

static/app/components/profiling/exportProfileButton.tsx

  const organization = useOrganization();

-  const project = useProjects().projects.find(p => {
+  const {projects} = useProjects({slugs: props.projectId ? [props.projectId] : []});


i think this one should just be empty if no projectId is set

dcramer · 2025-12-05T18:30:39Z

static/app/components/profiling/profilingBreadcrumbs.tsx

+        trail.type === 'profile summary' || trail.type === 'flamechart'
+    )
+    .map(trail => trail.payload.projectSlug);
+  const {projects} = useProjects({slugs: projectSlugs});


theres gotta be a better way to do breadcrumbs than pulling in projects like this - might need to just look at the payload. if its got slug, it might have name?

dcramer · 2025-12-05T18:31:00Z

static/app/utils/discover/teamKeyTransactionField.tsx

  ...props
 }: WrapperProps) {
-  const {projects} = useProjects();
+  const {projects} = useProjects({slugs: projectSlug ? [projectSlug] : []});


similar to the profiling one, project should be empty if no projectId? thus no projects defined?

dcramer · 2025-12-05T18:31:50Z

static/app/views/insights/pages/transactionCell.tsx


 export function TransactionCell({project, transaction, transactionMethod}: Props) {
-  const projects = useProjects();
+  const {projects} = useProjects({slugs: project ? [project] : []});


q: is project optional here becauase its not always present in the cells? does that mean we only need to look up project when its present similar to the other concerns with props above?

dcramer · 2025-12-05T18:32:17Z

static/app/views/issueDetails/groupDetails.tsx

  } = useGroup({groupId});

+  const groupProjectSlug = groupData?.project?.slug;
+  const {projects} = useProjects({slugs: groupProjectSlug ? [groupProjectSlug] : []});


if project slug isnt found we should hard error on the group - it means the project's missing/deleted/similar

dcramer · 2025-12-05T18:32:37Z

static/app/views/performance/newTraceDetails/traceDrawer/details/span/index.tsx

  const theme = useTheme();
-  const {projects} = useProjects();
+  const projectSlug = node.value.project_slug ?? node.event?.projectSlug;
+  const {projects} = useProjects({slugs: projectSlug ? [projectSlug] : []});


hard error on missing slug i believe - someone correct me if im wrong

dcramer · 2025-12-05T18:32:46Z

static/app/views/performance/newTraceDetails/traceDrawer/details/uptime/index.tsx

  const location = useLocation();
  const theme = useTheme();
-  const {projects} = useProjects();
+  const projectSlug = node.value.project_slug ?? node.event?.projectSlug;


hard error on missing slug i believe - someone correct me if im wrong

static/app/views/issueDetails/groupDistributionsDrawer.tsx

cursor · 2025-12-05T22:12:47Z

static/app/utils/useProjects.tsx

+        'This usage is deprecated and may break when all_projects=1 is removed. ' +
+        'Pass specific slugs to ensure projects are fetched on-demand.'
+    );
+  }


Bug: Deprecation warning fires repeatedly on every render

The console.warn for deprecation is executed directly in the function body rather than inside a useEffect or with a ref guard. This means the warning will fire on every single re-render of any component calling useProjects() without slugs, spamming the console with repeated warnings. The warning needs to be deduplicated, typically by using a ref to track whether it has already warned, or by placing it in a useEffect with empty dependencies.

Add a development-time console warning when useProjects() is called without the slugs parameter. This prepares for removing the all_projects=1 bootstrap fetch by encouraging explicit project fetching. Updates 18 components to pass specific slugs to useProjects(), ensuring they will continue working when projects are no longer pre-loaded.

static/app/views/issueDetails/groupDetails.tsx

cursor · 2025-12-05T22:57:31Z

static/app/views/profiling/profilesProvider.tsx

 }: ContinuousProfileProviderProps) {
  const api = useApi();
-  const {projects} = useProjects();
+  const {projects} = useProjects({slugs: projectSlug ? [projectSlug] : []});


Bug: Missing fetch state check causes false Sentry errors

The ContinuousProfileProvider now uses useProjects with specific slugs, but doesn't destructure the fetching state. When the project needs to be fetched from the API (not already in store), projects will be empty during the fetch. The useLayoutEffect runs immediately with the empty array, finds no project, and logs "Failed to fetch continuous profile - project not found" to Sentry - even though the project exists and is just being loaded. This causes false positive error reports. The component needs to check fetching before treating a missing project as an error.

dcramer requested review from a team as code owners December 5, 2025 18:27

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 5, 2025

sentry bot reviewed Dec 5, 2025

View reviewed changes

static/app/views/issueDetails/groupDetails.tsx Show resolved Hide resolved

cursor bot reviewed Dec 5, 2025

View reviewed changes

static/app/views/performance/newTraceDetails/traceDrawer/details/missingInstrumentation.tsx Show resolved Hide resolved

dcramer commented Dec 5, 2025

View reviewed changes

dcramer changed the title ~~ref(ui): Add deprecation warning to useProjects() without slugs~~ ref(ui): deprecate useProjects() without slugs Dec 5, 2025

dcramer force-pushed the use-projects-warning branch from c3bbdac to 4ac7fcf Compare December 5, 2025 21:02

vercel bot deployed to Preview December 5, 2025 21:05 View deployment

cursor bot reviewed Dec 5, 2025

View reviewed changes

static/app/views/issueDetails/groupDistributionsDrawer.tsx Show resolved Hide resolved

dcramer force-pushed the use-projects-warning branch from 4ac7fcf to a5bf981 Compare December 5, 2025 21:22

vercel bot deployed to Preview December 5, 2025 21:25 View deployment

dcramer force-pushed the use-projects-warning branch from a5bf981 to 4947b9a Compare December 5, 2025 21:25

vercel bot deployed to Preview December 5, 2025 21:28 View deployment

dcramer force-pushed the use-projects-warning branch from 4947b9a to 9d61aff Compare December 5, 2025 22:05

vercel bot deployed to Preview December 5, 2025 22:10 View deployment

cursor bot reviewed Dec 5, 2025

View reviewed changes

dcramer force-pushed the use-projects-warning branch from bf7c52d to 34f7904 Compare December 5, 2025 22:43

🛠️ apply pre-commit fixes

08773fd

sentry bot reviewed Dec 5, 2025

View reviewed changes

static/app/views/issueDetails/groupDetails.tsx Show resolved Hide resolved

vercel bot deployed to Preview December 5, 2025 22:48 View deployment

cursor bot reviewed Dec 5, 2025

View reviewed changes

Uh oh!

ref(ui): deprecate useProjects() without slugs #104462

Are you sure you want to change the base?

ref(ui): deprecate useProjects() without slugs #104462

Conversation

dcramer commented Dec 5, 2025

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot Dec 5, 2025

Choose a reason for hiding this comment

Bug: Deprecation warning fires repeatedly on every render

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot Dec 5, 2025

Choose a reason for hiding this comment

Bug: Missing fetch state check causes false Sentry errors

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Dec 5, 2025 •

edited

Loading