Skip to content

Conversation

@ryan953
Copy link
Member

@ryan953 ryan953 commented Jan 20, 2026

@ryan953 ryan953 requested review from a team as code owners January 20, 2026 17:05
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 20, 2026
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused about the path changes in the specs, why did you change them to api-tokens? LGTM otherwise

@ryan953
Copy link
Member Author

ryan953 commented Jan 22, 2026

I'm a little confused about the path changes in the specs, why did you change them to api-tokens? LGTM otherwise

When the definition of ApiQueryKey changes from [string] to be [ReturnType<typeof getApiUrl>] then these callsites will start to complain, and '/api/test/' is not a valid api endpoint url, so it got changed.

Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 4 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@ryan953 ryan953 merged commit b0e99bc into master Jan 23, 2026
53 checks passed
@ryan953 ryan953 deleted the ryan953/ref-getApiUrl-utils-actionCreators branch January 23, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants