-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore(preprod): Mark deprecated columns as ready for deletion #106591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rbro112
merged 5 commits into
master
from
ryan/mark_deprecated_columns_as_ready_for_deletion
Jan 21, 2026
Merged
chore(preprod): Mark deprecated columns as ready for deletion #106591
rbro112
merged 5 commits into
master
from
ryan/mark_deprecated_columns_as_ready_for_deletion
Jan 21, 2026
+80
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4ee6d6b to
60fbb6b
Compare
2a64de8 to
5edb4a8
Compare
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Moved preprodartifact.build_version field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.build_number field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.app_name field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.app_icon_id field to pending deletion state
--
-- (no-op) |
trevor-e
approved these changes
Jan 20, 2026
Base automatically changed from
ryan/remove_final_read_of_deprecated_columns
to
master
January 20, 2026 19:44
60fbb6b to
c70438e
Compare
c70438e to
c4c7cbe
Compare
c4c7cbe to
a556be0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Following https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns, this now properly marks the deprecated columns as ready for deletion, which sets us up to delete in #106592