-
Notifications
You must be signed in to change notification settings - Fork 542
App Submission: DCR Pulse #4121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
al-lac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @karamble,
thanks a lot for this awesome submission. 🔝
And good job on getting everything in place here.
Really great addition to the Umbrel Crypto Ecosystem! ⚡
I made some suggestions on what should be adjusted to get the app ready for the store.
dcrpulse/umbrel-app.yml
Outdated
| id: dcrpulse | ||
| name: Decred Pulse | ||
| tagline: Full Decred node with watch-only wallet and database-free block explorer | ||
| category: finance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crypto category would probably fit the best here.
| category: finance | |
| category: crypto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requested changes have been made. the category needs validation as it is giving a linter error as crypto seems to not be a valid category.
- Remove custom networks - Change port from 8080 to 8735 - Update to dcrd v2.1.2 and dcrwallet v2.1.2 - Update dashboard to v1.0.2 - Change category from finance to crypto - Fix description formatting for proper line breaks
|
all requested changes have been made. Linter error on the requested crypto - category |
❌ Linting failed with 1 error ❌Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store. Please review the linting results below and make any necessary changes to your submission. Linting Results
Legend
|
App Submission
App name
...
256x256 SVG icon
Gallery images
I have tested my app on: