-
Notifications
You must be signed in to change notification settings - Fork 542
App Submission: Rocket.Chat #4192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
App Submission: LinkStack - Self-hosted open-source Linktree alternative
|
| Severity | File | Description |
|---|---|---|
| ℹ️ | rocketchat/docker-compose.yml |
Potentially using unsafe user in service "db": The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000. |
| ℹ️ | rocketchat/docker-compose.yml |
Potentially using unsafe user in service "init-replica": The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000. |
| ℹ️ | rocketchat/docker-compose.yml |
Potentially using unsafe user in service "app": The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000. |
rocketchat/docker-compose.yml |
Invalid restart policy: The restart policy of the container "init-replica" should be set to "on-failure". |
|
rocketchat/umbrel-app.yml |
"icon" and "gallery" needs to be empty for new app submissions: The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team. |
Legend
| Symbol | Description |
|---|---|
| ❌ | Error: This must be resolved before this PR can be merged. |
| Warning: This is highly encouraged to be resolved, but is not strictly mandatory. | |
| ℹ️ | Info: This is just for your information. |
|
Hey @dennysubke, Thanks for yet another great submission 💯 Did you get the app running on one of your instances? With the currently committed code I currently get database errors and the app does not come up. With that config the app starts up for me: However, I either end up at the screen where I would need to verify an email to activate the instance, or I just get this screen due to the lack of HTTPS / Crypto functions: Not sure if we can work around these issues for now. Appreciate the work you put into this for sure! 👍 |
|
Hey @al-lac! Thanks a lot for the review, really appreciate it! 🙏 That’s a bit strange though, because on my side everything worked as expected and I did not run into any database errors. I will take another look after the holidays and see if I can reproduce it more reliably. 💪🏻 |
|
Thanks @dennysubke, no urgency here :-) Happy Holidays! |
|
Nice, thanks! Enjoy your holidays as well! 🎄 |

App Submission
Rocket.Chat
Icon
Gallery images
I have tested my app on: