LoadOp::DontCare #8549
Merged
LoadOp::DontCare #8549
+269
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
cw/dontcare
branch
2 times, most recently
from
8c19a28 to
0477714
Compare
cwfitzgerald
force-pushed
the
cw/dontcare
branch
2 times, most recently
from
c9af109 to
3926130
Compare
Wumpf
approved these changes
Dec 7, 2025
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
very nice! some asks for doc improvements, but pre-approving since there's nothing substantial
cwfitzgerald
force-pushed
the
cw/dontcare
branch
from
3926130 to
5eb66ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For native users who are always writing to all of their render target, this will provide the best performance on all hardware without needing to switch between Clear/Load depending on if they're running on a tiler or not.
I've also refactored wgpu-hal to actually have bitflags for all the variants, instead of having "no flags" have a special meeting.
Testing
Test pass. Going to add a test for DontCare before this is ready for review.
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.