Skip to content

Conversation

@ServeurpersoCom
Copy link
Collaborator

Make sure to read the contributing guidelines before submitting a PR

Minor cosmetics for logs :
Fixes argument order to follow convention: short form before long form (e.g., {"-x", "--xxx"} instead of {"--xxx", "-x"}).

This affects how arguments appear in logs since to_string() uses .back().

Found via: grep -n '{"--[a-z-]*", "-[a-z]' common/arg.cpp

Fixed 8 arguments:

  • -cram, --cache-ram
  • -kvu, --kv-unified
  • -ot, --override-tensor
  • -otd, --override-tensor-draft
  • -cmoe, --cpu-moe
  • -ncmoe, --n-cpu-moe
  • -cmoed, --cpu-moe-draft
  • -ncmoed, --n-cpu-moe-draft

@ngxson
Copy link
Collaborator

ngxson commented Dec 19, 2025

I think it's worth adding a check in test-arg-parser too:

  • If the option has more than one argument, make sure the first argument is shorter than the second
  • Apply the same check with arg_neg

@ServeurpersoCom
Copy link
Collaborator Author

"the SRV_INF macro should already be prefixed with the function name, so I think this is not necessary:
#define SRV_INF(fmt, ...) LOG_INF("srv %12.*s: " fmt, 12, func, VA_ARGS)"
Nice!

This PR just need test-arg-parser order with arg_neg

@ServeurpersoCom ServeurpersoCom force-pushed the fix/arg-order-short-before-long branch from 0931684 to 4d0d1c2 Compare December 19, 2025 13:02
@github-actions github-actions bot added the testing Everything test related label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples server testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants