feat(angular)!: migrate Angular-Slickgrid to Standalone Component#2339
feat(angular)!: migrate Angular-Slickgrid to Standalone Component#2339ghiscoding merged 8 commits intonextfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #2339 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 196 195 -1
Lines 23953 23949 -4
Branches 8415 8414 -1
=======================================
- Hits 23953 23949 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
angular-slickgrid
aurelia-slickgrid
slickgrid-react
slickgrid-vue
@slickgrid-universal/angular-row-detail-plugin
@slickgrid-universal/aurelia-row-detail-plugin
@slickgrid-universal/react-row-detail-plugin
@slickgrid-universal/vue-row-detail-plugin
@slickgrid-universal/binding
@slickgrid-universal/common
@slickgrid-universal/composite-editor-component
@slickgrid-universal/custom-footer-component
@slickgrid-universal/custom-tooltip-plugin
@slickgrid-universal/empty-warning-component
@slickgrid-universal/event-pub-sub
@slickgrid-universal/excel-export
@slickgrid-universal/graphql
@slickgrid-universal/odata
@slickgrid-universal/pagination-component
@slickgrid-universal/pdf-export
@slickgrid-universal/row-detail-view-plugin
@slickgrid-universal/rxjs-observable
@slickgrid-universal/text-export
@slickgrid-universal/utils
@slickgrid-universal/vanilla-bundle
@slickgrid-universal/vanilla-force-bundle
commit: |
|
@zewa666 @jr01 I would really like to get some real Angular user feedback like you guys. I haven't programmed much in Angular for the past 2 years, but I'm assuming that is the direction that we should go, is that correct? I'd really like to know if this is good to go with and/or if there could be negative side effect? This is obviously a major breaking change and is tagged to go in my upcoming Angular-Slickgrid v10 (I think I can release a Beta by next week and these changes are all mentioned in the migration guide). If you guys could do a quick review and provide feedback, that would be super helpful because like I said, I haven't used Angular in a while and I want to make sure this is something we should proceed with... or cancel, depending on your feedback. At least my Cypress tests are all passing, so I'm assuming that it's a good sign... If you have time for a review, I would like to emphasizes reviewing changes in these particular files
again I would really appreciate feedback and a review if possible before I merge this, because it is quite a major change and important to the end users like you guys, so... |
|
I'll check that out and let ya know begin next week |
|
yes, I'll have a look and also asked a collegae to give feedback - expect early next week |
zewa666
left a comment
There was a problem hiding this comment.
only a few minor things. Aside from that everything looks good for me
frameworks/angular-slickgrid/src/library/components/angular-slickgrid.component.ts
Outdated
Show resolved
Hide resolved
frameworks/angular-slickgrid/src/library/components/angular-slickgrid.component.ts
Show resolved
Hide resolved
| standalone: false, | ||
| imports: [NgTemplateOutlet], | ||
| }) | ||
| export class AngularSlickgridComponent<TData = any> implements AfterViewInit, OnDestroy { |
There was a problem hiding this comment.
perhaps while at it, we could offer a customClass binding to the slickgridContainer-xyz div, so that its easier to attach custom css classes to the inside of the component
There was a problem hiding this comment.
@zewa666 can you provide the changes that are required for this or create a PR on the next branch for this?
There was a problem hiding this comment.
I'll create a PR after this gets merged
|
Hi @ghiscoding, Sorry for responding a bit later than promised, too much on the plate. 😅 I didn't look myself into this - I just fully delegated this task to Claude Opus 4.5 using our codebase and your PR (files & comments). Sorry about that as well 😉 Here is what it wrote: I've reviewed this PR against our production Angular 21 application that uses Angular-Slickgrid. Here's my assessment: ✅ The migration looks good and is the right direction. We're using Angular 21 with zoneless change detection ( Our Usage Pattern:
Migration Impact for us:
Technical Observations:
Re: Signal-based Inputs discussion: Verdict: 👍 Approve - this is a solid modernization. The breaking change is justified and the migration path is clear. |
|
@jr01 ok great thanks for the feedback nonetheless, it's still quite informative since it's compared with your actual code. Just a side note though, for the comment below,
I'm also actually going Zoneless as well but that was done in a separate PR #2341 since it's a different topic, so just in case you missed that other PR, it will be Standalone and Zoneless 😉
Great I think we all agreed on the same end goal, it's great to modernize but doing in step is also a good idea and I will add a comment in the migration guide for possible "future changes". Thanks for all the feedback, well worth it and that should benefit everyone 😄 |
|
🎉 This pull request is included in version 10.0.0-beta.0 📦 |
migrate Angular-Slickgrid to Standalone Component (dropping
AngularSlickgridModule)