Skip to content

feat(builders): extend alias typing, add write_table, timestamp & richer type support #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
giospada wants to merge 7 commits into from
Closed

feat(builders): extend alias typing, add write_table, timestamp & richer type support #1

giospada wants to merge 7 commits into from

Conversation

@giospada
Copy link
Owner

@giospada giospada commented Dec 1, 2025 •
edited
Loading

  • Make alias hints optional in extended expression builders.
  • Let cast use _alias_or_inferred(...) instead of hardcoded name.
  • Add write_table plan builder.
  • Extend Substrait type parsing/covers to support for various parameterized types.
  • Fix infer_expression_type for if branches
  • add tests for write_table and type cover checks.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

ACTION NEEDED

Substrait follows the Conventional Commits
specification for
release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@giospada giospada changed the title Temp contribution <type>[optional scope]: <description> Dec 1, 2025
@giospada giospada changed the title <type>[optional scope]: <description> feat(builders): extend alias typing, add write_table, timestamp & richer type support; fix cast naming and if-type inference Dec 1, 2025
@giospada giospada changed the title feat(builders): extend alias typing, add write_table, timestamp & richer type support; fix cast naming and if-type inference feat(builders): extend alias typing, add write_table, timestamp & richer type support; fix cast naming and if-type inference Dec 1, 2025
@giospada giospada changed the title feat(builders): extend alias typing, add write_table, timestamp & richer type support; fix cast naming and if-type inference feat(builders): extend alias typing, add write_table, timestamp & richer type support Dec 1, 2025
mbwhite
mbwhite approved these changes Dec 1, 2025
View reviewed changes
Copy link

@mbwhite mbwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giospada giospada force-pushed the temp_contribution branch 2 times, most recently from c16a94b to ff27079 Compare December 2, 2025 13:19
giospada and others added 4 commits December 2, 2025 14:57
@giospada
feat(types): add many new types and tighten nullability/precision checks
ef8f4bc 
Add wide-ranging support for additional scalar and parameterized Substrait types, improve parameter handling, and make nullability/precision checks stricter and more correct.

Signed-off-by: MBWhite <whitemat@uk.ibm.com>
@giospada
feat(write_table): added the write table builder and test
4c0a656 
Signed-off-by: AGV <agv@zurich.ibm.com>
@giospada
fix: if_then and switch_expresion calling o infer_expression_type
b507c37
@giospada
fix: ruff and type hints
92941e9
@giospada giospada closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mbwhite mbwhite mbwhite approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@giospada @mbwhite