release: ifdef compile ESRP steps #2241
Merged
+350
−346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move from a runtime `condition` on the ESRP steps to a YAML parse-time condition so that no usage of the `esrp*ConnectionName` variables exist when the esrp parameter is false. This means we can avoid the need to approve runs of this workflow in the internal secure environment when not accessing ESRP (for example, when debugging and testing the release process). Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
dscho
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from a runtime
conditionon the ESRP steps to a YAML parse-time condition so that no usage of theesrp*ConnectionNamevariables exist when the esrp parameter is false.This means we can avoid the need to approve runs of this workflow in the internal secure environment when not accessing ESRP (for example, when debugging and testing the release process).